Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 308845 - net-im/pidgin-2.6 IRIX fixes
Summary: net-im/pidgin-2.6 IRIX fixes
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All IRIX
: High normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-10 16:48 UTC by Stuart Shelton
Modified: 2010-06-04 00:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
pidgin-2.6.1-irix.patch (pidgin-2.6.1-irix.patch,841 bytes, patch)
2010-03-10 16:52 UTC, Stuart Shelton
Details | Diff
pidgin-2.6.1-perl.patch (pidgin-2.6.1-perl.patch,916 bytes, patch)
2010-03-11 13:16 UTC, Stuart Shelton
Details | Diff
pidgin-2.6.1-perl.patch (pidgin-2.6.1-perl.patch,916 bytes, patch)
2010-03-15 11:34 UTC, Stuart Shelton
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stuart Shelton 2010-03-10 16:48:38 UTC
As well as removing the 'intltoolize' call from pidgin (Bug 307653), the following (attached) additional patches are needed on IRIX.

I also modified the ebuild as follows:

 src_configure() {
-       # Stabilize things, for your own good
-       strip-flags
-       replace-flags -O? -O2
+       if [[ ${CHOST} == *-irix* ]]; then
+               epatch "${FILESDIR}"/${PN}-2.6.1-perl.patch \
+                   || die "IRIX perl patch failed"
+               # valgrind isn't available on IRIX, and the RUNNING_ON_IRIX
+               # macro confuses the MIPSpro compilers...
+               epatch "${FILESDIR}"/${PN}-2.6.1-irix.patch \
+                   || die "IRIX patch failed"
+       else
+               # Stabilize things, for your own good
+               strip-flags
+               replace-flags -O? -O2
+       fi
 
        local myconf

... after this, the remaining problem is following output at the end of the build:

>>> Original instance of package unmerged safely.
 * Installing GNOME 2 GConf schemas
/usr/opt/portage/var/tmp/portage/net-im/pidgin-2.6.5/temp/environment: line 2682: pgrep: command not found

... pgrep is from sys-process/procps, and so likely won't exist on any non-Linux system.  This is probably a generic problem with an eclass rather than anything related directly to pidgin - but pidgin is the only package which I can recall producing this output.
Comment 1 Stuart Shelton 2010-03-10 16:52:39 UTC
Created attachment 223017 [details, diff]
pidgin-2.6.1-irix.patch


Did I say RUNNING_ON_IRIX before?  I meant RUNNING_ON_VALGRIND ;)


MIPSpro chokes on '{ }' - but this change seems to do the right thing.
Comment 2 Stuart Shelton 2010-03-11 13:16:07 UTC
Created attachment 223145 [details, diff]
pidgin-2.6.1-perl.patch


... and this change should fix the perl module: __attribute__ ((constructor)) is a GNU extension, and #pragma init appears to be a Sun extension.

On IRIX, the linker must be passed the -init option along with the function to execute on load.
Comment 3 Stuart Shelton 2010-03-15 11:34:03 UTC
Created attachment 223621 [details, diff]
pidgin-2.6.1-perl.patch


Ensure GNU-specific options are only used with GCC, and replicate the on-load logic to the linker (which is fine, as this patch can be guarded with '[[ $CHOST == *-irix* ]]').
Comment 4 Stuart Shelton 2010-03-15 11:35:11 UTC
Seem to have attached that last patch twice, sorry ;)
Comment 5 Fabian Groffen gentoo-dev 2010-04-03 09:32:13 UTC
(In reply to comment #0)
> ... after this, the remaining problem is following output at the end of the
> build:
> 
> >>> Original instance of package unmerged safely.
>  * Installing GNOME 2 GConf schemas
> /usr/opt/portage/var/tmp/portage/net-im/pidgin-2.6.5/temp/environment: line
> 2682: pgrep: command not found
> 
> ... pgrep is from sys-process/procps, and so likely won't exist on any
> non-Linux system.  This is probably a generic problem with an eclass rather
> than anything related directly to pidgin - but pidgin is the only package which
> I can recall producing this output.

It's a Solaris thing actually, that was imitated in procps for Linux.  I don't have it either on OSX, and it comes from gnome2-utils.eclass.  It's trying to SIGHUP your gconfd-2 if running.  Not sure how to fix it the best way.
Comment 6 Olivier Crete (RETIRED) gentoo-dev 2010-06-04 00:47:44 UTC
Please send these patches upstream. I maintain a strict upstream-first policy for pidgin.