Bug 308643 – net-nntp/slrn-1.0.0_pre18 version bump

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Sebastian Lüttich 2010-03-09 13:26:00 UTC]

an ebuild for the 12/02/09 svn snapshot from slrn 1.0.0

Reproducible: Always

[Comment 1 Sebastian Lüttich 2010-03-09 13:26:38 UTC]

Created attachment 222827 [details]
slrn-1.0.0_pre18 ebuild

[Comment 2 Sebastian Lüttich 2010-03-09 13:27:03 UTC]

Created attachment 222829 [details]
necessary patch -> goes to $FILESDIR

[Comment 3 Tim Harder 2010-04-10 09:00:50 UTC]

A diff from the most recent ebuild version to your new version is preferred so it is easy to see what has been changed.

Also, it's better to use old patches already in the tree if they still work instead of creating new patches to keep code duplication at a minimum. In this case, it appears that the attached don't strip patch is still equivalent to the old patch already in the tree.

Thanks for your work.

[Comment 4 Tim Harder 2010-04-10 09:15:29 UTC]

Created attachment 227215 [details, diff]
Ebuild updates for slrn-1.0.0_pre18

Ebuild updates for slrn-1.0.0_pre18:
  * Use EAPI 2 for src_prepare and src_configure phases
  * Update MY_P, SRC_URI, and S to work with the new tarballs
  * Apply old don't strip patch in src_prepare phase
  * Use src_configure phase and rely on default src_compile phase (explicit emake call is unnecessary)
  * Explicit die for econf unnecessary as this should now be handled by the package manager

[Comment 5 Sebastian Lüttich 2010-04-10 11:57:10 UTC]

(In reply to comment #4)
> Created an attachment (id=227215) [details]
> Ebuild updates for slrn-1.0.0_pre18

Thanks alot for your effort.  I did a quick diff to include canlock-support and corrected the: "$(use_with uudeview)"-part.

slrns configure needs "--with-uu" to compile uudeview support.

regards, Sebastian

[Comment 6 Sebastian Lüttich 2010-04-10 11:57:40 UTC]

Created attachment 227253 [details, diff]
patch to include cancel-lock support

[Comment 7 Tim Harder 2010-04-10 19:34:41 UTC]

(In reply to comment #5)
> slrns configure needs "--with-uu" to compile uudeview support.

Oops, I missed that in your original ebuild. It's easier to still use the use_with function though so I'll update my patch.

Also, it should be noted that in order to add canlock support to slrn, canlock should be added to the tree (bug #104244).

[Comment 8 Sebastian Lüttich 2010-04-10 19:57:45 UTC]

(In reply to comment #7)

> Also, it should be noted that in order to add canlock support to slrn, canlock
> should be added to the tree (bug #104244).

I posted a new version (net-libs/canlock-2_beta) there are changes to src, home and some minor changes to use the original debian-sources.

[Comment 9 Tim Harder 2010-04-10 23:33:48 UTC]

Created attachment 227329 [details, diff]
Ebuild updates for slrn-1.0.0_pre18

Additional changes from my last patch:
  * Add canlock support (canlock needs to be added to the tree bug #104244)
  * Fix uudeview configure flag

[Comment 10 Tim Harder 2011-09-30 10:19:58 UTC]

Added to CVS.