Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 308363 - mail-client/mozilla-thunderbird-3.0.3 alsa USE flag request
Summary: mail-client/mozilla-thunderbird-3.0.3 alsa USE flag request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-07 19:03 UTC by Marcus Becker
Modified: 2010-03-21 22:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild with alsa use flag (mozilla-thunderbird-3.0.3.ebuild,6.53 KB, text/plain)
2010-03-07 19:04 UTC, Marcus Becker
Details
x11-plugins/enigmail-1.0.1-r1 with alsa USE flag (enigmail-1.0.1-r1.ebuild,4.14 KB, text/plain)
2010-03-07 19:25 UTC, Marcus Becker
Details
alsa USE flag for x11-plugins/enigmail-1.0.1-r1 (alsa_use_enigmail.patch,212 bytes, patch)
2010-03-08 00:49 UTC, Marcus Becker
Details | Diff
alsa USE flag for mail-client/mozilla-thunderbird-3.0.3 (alsa_use_thunderbird.patch,263 bytes, patch)
2010-03-08 00:50 UTC, Marcus Becker
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus Becker 2010-03-07 19:03:17 UTC
mozilla-thunderbird needs alsa to compile

I added alsa USE-flag to configure it with: --disable-ogg --disable-wave

tested and works on ~AMD64

Reproducible: Always

Steps to Reproduce:
1. do not use alsa
2. emerge mozilla-thunderbird
3. 

Actual Results:  
checking for libgnome-2.0 >= 2.0... checking for dbus-glib-1 >= 0.60... yes
checking MOZ_DBUS_GLIB_CFLAGS... -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include
checking MOZ_DBUS_GLIB_LIBS... -ldbus-glib-1 -ldbus-1 -lpthread -lrt -lgobject-2.0 -lglib-2.0
checking for alsa... Package alsa was not found in the pkg-config search path.
Perhaps you should add the directory containing `alsa.pc'
to the PKG_CONFIG_PATH environment variable
No package 'alsa' found
configure: error: Need alsa for Ogg or Wave decoding on Linux.  Disable with --disable-ogg --disable-wave.

!!! Please attach the following file when seeking support:
!!! /tmp/portage/mail-client/mozilla-thunderbird-3.0.3/work/comm-1.9.1/config.log
 * ERROR: mail-client/mozilla-thunderbird-3.0.3 failed:
 *   econf failed
 *
 * Call stack:
 *     ebuild.sh, line   54:  Called src_configure
 *   environment, line 3547:  Called econf
 *     ebuild.sh, line  544:  Called die
 * The specific snippet of code:
 *                      die "econf failed"
 *
 * If you need support, post the output of 'emerge --info =mail-client/mozilla-thunderbird-3.0.3',
 * the complete build log and the output of 'emerge -pqv =mail-client/mozilla-thunderbird-3.0.3'.
 * This ebuild is from an overlay: '/usr/local/portage/'
 * The complete build log is located at '/tmp/portage/mail-client/mozilla-thunderbird-3.0.3/temp/build.log'.
 * The ebuild environment file is located at '/tmp/portage/mail-client/mozilla-thunderbird-3.0.3/temp/environment'.
 * S: '/tmp/portage/mail-client/mozilla-thunderbird-3.0.3/work/comm-1.9.1'


Expected Results:  
compiling

I added my ebuild as attachment:
22c22
< IUSE="alsa ldap crypt bindist lightning mozdom system-sqlite"
---
> IUSE="ldap crypt bindist lightning mozdom system-sqlite"
160,164d159
<
<         if ! use alsa; then
<                 mozconfig_annotate '' --disable-ogg --disable-wave
<         fi
<
Comment 1 Marcus Becker 2010-03-07 19:04:38 UTC
Created attachment 222543 [details]
ebuild with alsa use flag
Comment 2 Marcus Becker 2010-03-07 19:25:24 UTC
Created attachment 222545 [details]
x11-plugins/enigmail-1.0.1-r1 with alsa USE flag

also breaks without alsa
Comment 3 Jory A. Pratt gentoo-dev 2010-03-07 23:06:28 UTC
(In reply to comment #1)
> Created an attachment (id=222543) [details]
> ebuild with alsa use flag
> 

(In reply to comment #2)
> Created an attachment (id=222545) [details]
> x11-plugins/enigmail-1.0.1-r1 with alsa USE flag
> 
> also breaks without alsa
> 

Marcus, this is acceptable, but if you would please review the changes in firefox-3.6/xulrunner-1.9.2 for how we handle alsa. I would rather keep the builds unified, also when attaching changes please use diffs. If you would fix this and update the attachment for a single diff I would be happy to get it applied for you.
Comment 4 Marcus Becker 2010-03-08 00:49:18 UTC
Created attachment 222603 [details, diff]
alsa USE flag for x11-plugins/enigmail-1.0.1-r1
Comment 5 Marcus Becker 2010-03-08 00:50:31 UTC
Created attachment 222605 [details, diff]
alsa USE flag for mail-client/mozilla-thunderbird-3.0.3

sorry :)
Comment 6 Jory A. Pratt gentoo-dev 2010-03-08 02:10:40 UTC
Index: mozilla-thunderbird-3.0.3-r1.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/mail-client/mozilla-thunderbird/mozilla-thunderbird-3.0.3-r1.ebuild,v
retrieving revision 1.1
diff -u -B -r1.1 mozilla-thunderbird-3.0.3-r1.ebuild
--- mozilla-thunderbird-3.0.3-r1.ebuild	7 Mar 2010 20:51:54 -0000	1.1
+++ mozilla-thunderbird-3.0.3-r1.ebuild	8 Mar 2010 02:08:30 -0000
@@ -19,7 +19,7 @@
 KEYWORDS="~alpha ~amd64 ~ia64 ~ppc ~ppc64 ~sparc ~x86 ~x86-fbsd"
 SLOT="0"
 LICENSE="|| ( MPL-1.1 GPL-2 LGPL-2.1 )"
-IUSE="ldap crypt bindist lightning mozdom system-sqlite"
+IUSE="alsa ldap crypt bindist lightning mozdom system-sqlite"
 PATCH="${PN}-3.0-patches-0.3"
 
 REL_URI="http://releases.mozilla.org/pub/mozilla.org/thunderbird/releases"
@@ -148,6 +148,8 @@
 	# Use enable features
 	mozconfig_use_enable lightning calendar
 	mozconfig_use_enable system-sqlite
+	mozconfig_use_enable alsa ogg
+	mozconfig_use_enable alsa wave
 
 	# Bug #72667
 	if use mozdom; then

Marcus this is what I was hoping you would have gotten out of my comment. This is a match to that of firefox/xulrunner. I will work to get this commited to the tree in a few days along with other bug fixes. Thanks for your attempt to rework your patches hope this example helps you in the future. Also please not a unified diff is always prefered in the gentoo community, diff -urN will get ya the results.
Comment 7 Charles McGarvey 2010-03-10 20:54:00 UTC
Thanks Jory for working to get this fix applied.  There probably aren't many of us using thunderbird without alsa, but I also run into this bug today.
Comment 8 Jory A. Pratt gentoo-dev 2010-03-21 22:36:55 UTC
-r2 is in the tree :) thanks for your patients with this.