Bug 308291 – app-arch/cfv: Verify and potentially improve Python-related code

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Arfrever Frehtes Taifersar Arahesis (RETIRED) 2010-03-07 17:06:29 UTC]

- If this package could support installation for multiple versions of Python,
  then please try to adjust the ebuilds to support it.
- Ensure that the ebuilds do not use deprecated functions or variables.
- Please check if Python 3 is supported by this package.
- If this package does not support Python 3:
  - Specify dependency on Python 2.
    You can use PYTHON_DEPEND helper variable, which should be set before
    inheriting of python eclass.
  - If this package cannot support installation for multiple versions of
    Python, then set active version of Python using
    python_set_active_version().
  - Ensure that shebangs in installed scripts specify correct version of
    Python. If shebangs are too generic (e.g. '#!/usr/bin/python'), then you
    can use python_convert_shebangs() to convert shebangs.
    (Wrapper scripts generated by python_generate_wrapper_scripts() do not
    require any changes.)

Please see documentation [1] for more details.
[1] http://www.gentoo.org/proj/en/Python/developersguide.xml

[Comment 1 Ian Delaney (RETIRED) 2011-11-12 12:35:04 UTC]

Created attachment 292271 [details]
ebuild patch

can't emerge in python 2.5
Otherwise tested, all AOK.  Usual bump to EAFI 3.

[Comment 2 Arfrever Frehtes Taifersar Arahesis 2011-11-13 02:10:54 UTC]

Portage itself requires Python >=2.6 and it has no relation to Python version
required by other packages. If you install sys-apps/portage with USE="python3",
then you will be able to set active version of Python 2 to 2.4 or 2.5 and still
use Portage (Portage will use active version of Python 3 regardless of active
version of Python 2).

Use PYTHON_DEPEND="2".
Such pkg_setup() is not needed.

[Comment 3 Ian Delaney (RETIRED) 2011-11-14 09:12:57 UTC]

Created attachment 292489 [details, diff]
ebuild patch revised

done

[Comment 4 Arfrever Frehtes Taifersar Arahesis 2011-11-14 19:34:36 UTC]

(In reply to comment #3)

Shebang in /usr/bin/cfv should be fixed.

[Comment 5 Ian Delaney (RETIRED) 2011-11-15 06:47:24 UTC]

Created attachment 292593 [details, diff]
revised ebuild patch

done

[Comment 6 Arfrever Frehtes Taifersar Arahesis 2011-11-16 18:35:06 UTC]

(In reply to comment #5)

This patch is identical to previous patch.

[Comment 7 Ian Delaney (RETIRED) 2011-11-17 00:41:36 UTC]

Created attachment 292823 [details, diff]
revised ebuild patch

[Comment 8 Arfrever Frehtes Taifersar Arahesis 2011-11-18 01:07:17 UTC]

(In reply to comment #7)

In cfv-1.18.3.ebuild, dependency on Python will be specified using PYTHON_DEPEND, so dev-lang/python in explicit RDEPEND is not needed.

[Comment 9 Ian Delaney (RETIRED) 2011-11-18 09:39:23 UTC]

Created attachment 292973 [details, diff]
revised ebuild patch

sheeesh;  missed one. practice practice practice

[Comment 10 Sven Wegener 2012-12-02 22:17:43 UTC]

Thanks, commited.