Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 307685 - x11-themes/xfce4-icon-theme should have IUSE="minimal" and {tango,gnome}-icon-theme behind it
Summary: x11-themes/xfce4-icon-theme should have IUSE="minimal" and {tango,gnome}-icon...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-03 21:39 UTC by Mark Knecht
Modified: 2011-01-30 18:38 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Knecht 2010-03-03 21:39:34 UTC
If xfce4-meta is installed on a new machine as the only desktop manager then a few items in the main menu have no icons

Reproducible: Always

Steps to Reproduce:
1. emerge xfce4-meta
2. use the system
3. click on menu, some icons missing

Actual Results:  
5 icons missing

Expected Results:  
All menu entries should at least have an icom

shown me an icon for each entry in the default menus.

NOTE: Installing something like tango-icon-theme solves the problem. Possibly it or something lighter could be added to the ebuild?
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2010-03-03 22:24:40 UTC
Here is how it works:

xfce-base/xfce4-meta pulls in x11-themes/xfce4-icon-theme, and if you look at the version of xfce4-icon-theme, it's at 4.4.3. that's because it's a bit unmaintained upstream, so it's missing some of the icons

xfce4-icon-theme installs theme called Rodent, and a file:

/usr/share/icons/Rodent/index.theme

this file Inherits other themes:

Inherits=Tango,gnome,Industrial

it prefers Tango if it's installed

so I guess we could add a minimal USE flag to x11-themes/xfce4-icon-theme, and if it's not enabled, it will pull either tango-icon-theme or gnome-icon-theme

IUSE="minimal"

!minimal? ( || ( x11-themes/tango-icon-theme x11-themes/gnome-icon-theme )
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2010-03-03 22:24:51 UTC
darkside, any thoughts?
Comment 3 Mark Knecht 2010-03-03 22:39:37 UTC
If it matters the icons that were missing on this recent install were

Settings, 
Accessories 
Development 
Multimedia 
System

All other menu items as well as applications that showed up in the menus by default had icons and looked good.

Clearly this isn't terribly important and the folks on the xfce-users list didn't seem surprised as they seem to load other icon themes anyway. I'm just reporting it so that there's less frustration when someone else comes looking for an answer or so that you all can fix it if you think it a good thing.
Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-03-03 22:48:38 UTC
Well, it is a minor detail, but we should address it...I agree. I've been struggling with how to provide the best default user experience with xfce myself. Even I was abit confused on a recent install, mainly because I forgot about it.

I see no problem with comment #1 since USE=minimal is not enabled by default. A new install would have all the icons working as expected. A "good thing" imo at *minor* cost to compile times/etc :)
Comment 5 Mark Knecht 2010-03-03 22:52:56 UTC
BTW - on my wife's machine I didn't really find tango-icon-themes to be all that light as it pulled in something like 9 or 10 packages which seemed like overkill to get 5 icons, but it did work and looks good so maybe it's the best option for now.
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2010-03-03 23:05:05 UTC
well, tango-icon-theme needs imagemagick to build .png icons out of .svg ones, and building imagemagick takes long as building xfce's core packages together... that's why I never added the depend in before, most users just want to get into the desktop and X on first installs, and then install what they need
Comment 7 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-03-03 23:16:53 UTC
(In reply to comment #6)
> well, tango-icon-theme needs imagemagick to build .png icons out of .svg ones,
> and building imagemagick takes long as building xfce's core packages
> together... that's why I never added the depend in before, most users just want
> to get into the desktop and X on first installs, and then install what they
> need

Yea, I guess that is what I am struggling with. Let's wait for a abit and I will attempt to formulate a poll so it isn't just the 3 of us trying to decide :)
Comment 8 Mark Knecht 2010-03-03 23:19:22 UTC
Yep. imagmagick was the big one, and it's really too much to just get 5 icons. On my AMD64 Core i5 machine where I have Gnome & KDE but use XFCE I have some apps that require it so it might only be that it gets built earlier getting called in at XFCE build time but I didn't like the imagmagick bit when I first saw that.
Comment 9 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-03-03 23:21:51 UTC
At risk of spamming the bug again...An idea just floated in my head. Can we
pre-process the missing icons from the tango set and ship them with the
xfce4-icon-theme package? It is rather ugly to maintain, but it should be "do
once and forget"

??
Comment 10 Samuli Suominen (RETIRED) gentoo-dev 2010-08-24 03:25:48 UTC
I'm closing this again WONTFIX. Leaving it to users to install themes they want.
Comment 11 Samuli Suominen (RETIRED) gentoo-dev 2011-01-30 18:38:19 UTC
reopen
Comment 12 Samuli Suominen (RETIRED) gentoo-dev 2011-01-30 18:38:49 UTC
xfce4-icon-theme has USE=minimal now, the missing icons got a lot worse with Xfce 4.8, so it was about time to add this.