Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 307411 - prpltwtr-0.4.1 - [new w/ ebuild] a twitter-plugin for net-im/pidgin
Summary: prpltwtr-0.4.1 - [new w/ ebuild] a twitter-plugin for net-im/pidgin
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Default Assignee for New Packages
URL:
Whiteboard: sunrise suggested
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-02 03:26 UTC by avx
Modified: 2012-02-19 08:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
prpltwtr-0.4.1.ebuild (prpltwtr-0.4.1.ebuild,942 bytes, text/plain)
2010-03-02 03:27 UTC, avx
Details
prpltwtr-0.4.1-respect-destdir.patch (prpltwtr-0.4.1-respect-destdir.patch,397 bytes, patch)
2010-03-02 03:28 UTC, avx
Details | Diff
prpltwtr-0.4.1.ebuild (prpltwtr-0.4.1.ebuild,958 bytes, text/plain)
2010-03-02 13:53 UTC, avx
Details
prpltwtr-0.4.1-respect-destdir.patch (prpltwtr-0.4.1-respect-destdir.patch,409 bytes, patch)
2010-03-02 13:53 UTC, avx
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description avx 2010-03-02 03:26:51 UTC
prpltwtr is a plugin for libpurple-based IM-clients (pidgin, ...), which adds support for microblogging (twitter, ...) to the client.

Current version is prpltwtr-0.4.1 released @2010/02/10

The ebuild is for the current version and incorporates some minor fixes to respect DESTDIR and to make it work with CLI-only clients - also adding "-j1".

Works (for me) on ~amd64 and ~x86, tested with net-im/minbif-1.0.1. If a dev finds it working and good enough concerning QA, please include into portage. Thanks.

Reproducible: Always

Steps to Reproduce:
1. download to overlay
2. digest/manifest
3. emerge
4. try using with a appropriate client

Actual Results:  
Works (for me)

Expected Results:  
Works (for me)
Comment 1 avx 2010-03-02 03:27:48 UTC
Created attachment 221731 [details]
prpltwtr-0.4.1.ebuild
Comment 2 avx 2010-03-02 03:28:16 UTC
Created attachment 221733 [details, diff]
prpltwtr-0.4.1-respect-destdir.patch
Comment 3 Peter Volkov (RETIRED) gentoo-dev 2010-03-02 05:50:50 UTC
Thank you for your work Manu. I'd like to suggest to put this plugin into Sunrise overlay http://overlays.gentoo.org/proj/sunrise/ This way developers will better review this ebuild and more users could easily use it.

While we are here, some comments on ebuild:

1. epatch should be in src_prepare().
2. Why do you need DESTDIR=${D} in src_compile? I guess it's safe to drop it.
3. DESTDIR=${D} <- ${D} should be quoted here.
4.
! use gtk && \
		sed '6i\IS_PIDGIN=0' global.mak && \
		sed -i "s:Home Timeline:Timeline:g" twitter.c

I think it's better to rewrite something like:

if ! use gtk; then
    sed '6i\IS_PIDGIN=0' global.mak || die 
    sed -i "s:Home Timeline:Timeline:g" twitter.c || die
fi

This way emerge aborts if sed fails.

5. prpltwtr-0.4.1-respect-destdir.patch - Makefile's should respect DESTDIR, not D, thus patch should contain $(DESTDIR) (and note round quotes, this is common convention to use them in such cases).
Comment 4 avx 2010-03-02 13:52:48 UTC
(In reply to comment #3)
> While we are here, some comments on ebuild:
> [...]

New ebuild/patch with working fixes follows. Thanks for your suggestions.

> I'd like to suggest to put this plugin into Sunrise overlay.
> This way developers will better review this ebuild and
> more users could easily use it.

To be honest, I guess I won't. Besides the fact that I hate overlays, I find the process to get an account to cumbersome, instead of encouraging people to help/post new stuff it's more of a burden to me and I don't like to support that. Sorry - but whoever wants to push it to sunrise, they may do so.
Comment 5 avx 2010-03-02 13:53:23 UTC
Created attachment 221791 [details]
prpltwtr-0.4.1.ebuild
Comment 6 avx 2010-03-02 13:53:45 UTC
Created attachment 221793 [details, diff]
prpltwtr-0.4.1-respect-destdir.patch
Comment 7 Jeff (JD) Horelick (RETIRED) gentoo-dev 2012-02-19 08:01:04 UTC
prpltwtr-0.11.0 is now in the tree. Closing.