Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 307099 - media-sound/{squeezecenter,squeezeboxserver} - bogus bonjour USE flag
Summary: media-sound/{squeezecenter,squeezeboxserver} - bogus bonjour USE flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Joe Peterson (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-27 19:59 UTC by Doktor Notor
Modified: 2010-06-27 08:03 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Doktor Notor 2010-02-27 19:59:29 UTC
$ grep bonjour ${PORTDIR}/media-sound/squeezeboxserver/*.ebuild 
IUSE="lame wavpack musepack alac ogg flac avahi aac bonjour"
	bonjour? ( net-misc/mDNSResponder )

Hmmm?

$ grep bonjour ${PORTDIR}/media-sound/squeezeboxserver/*.ebuild
squeezecenter-7.1.0-r1.ebuild:IUSE="lame wavpack alac ogg bonjour flac avahi"
squeezecenter-7.1.0-r1.ebuild:	bonjour? ( net-misc/mDNSResponder )
squeezecenter-7.3.0.ebuild:IUSE="lame wavpack alac ogg bonjour flac avahi"
squeezecenter-7.3.0.ebuild:	bonjour? ( net-misc/mDNSResponder )
squeezecenter-7.3.3-r1.ebuild:IUSE="lame wavpack alac ogg bonjour flac avahi aac"
squeezecenter-7.3.3-r1.ebuild:	bonjour? ( net-misc/mDNSResponder )

- Merely adding dependencies via USE flags that do nothing useful otherwise (compile-time or whatever) is not really valid. 
- What's net-misc/mDNSResponder doing useful for these packages and why isn't net-dns/avahi[mdnsresponder-compat] enough to do the same, just in case it actually does something.

Thanks.
Comment 1 Stuart Hickinbottom 2010-03-01 22:14:53 UTC
Good spot - prior to 7.4 SqueezeCenter used mDNSResponderPosix to provide Bonjour support. mDNSResponder is what Logitech packaged and tested, and so that's why I added support for it under Gentoo at the time.

You've made me re-check, though, and I see with 7.4 that they've dropped support for this.

I'm working on a 7.4.2 updated ebuild - I'll remove Avahi and Bonjour use flags and dependencies as you're correct that they are now redundant.
Comment 2 Doktor Notor 2010-03-01 22:26:11 UTC
OK, thanks for checking this ;)
Comment 3 Stuart Hickinbottom 2010-03-30 07:28:41 UTC
I've just submitted the ebuild of squeezeboxserver-7.4.2 to Joe for checking and, hopefully, inclusion in Portage soon. That removes these flag from IUSE.