Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 306785 - [gnome-overlay] x11-libs/vte-0.22.5 doesn't compile against x11-libs/gtk+-2.19.5
Summary: [gnome-overlay] x11-libs/vte-0.22.5 doesn't compile against x11-libs/gtk+-2.19.5
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: gtk+-2.20
  Show dependency tree
 
Reported: 2010-02-25 10:23 UTC by Tommaso Pasini
Modified: 2010-07-04 09:36 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
vte-0.22.5 build log (build.log,21.64 KB, text/plain)
2010-02-25 10:23 UTC, Tommaso Pasini 		Details
vte-0.23.5 build log with all the warnings (build.log,40.49 KB, text/plain)
2010-02-25 10:32 UTC, Tommaso Pasini 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tommaso Pasini 2010-02-25 10:23:05 UTC 
The subject says all. The error is
vte.c: In function ‘vte_terminal_paint_area’:
vte.c:10357: error: implicit declaration of function ‘GTK_WIDGET_DOUBLE_BUFFERED’
vte.c:10357: warning: nested extern declaration of ‘GTK_WIDGET_DOUBLE_BUFFERED’

I bumped the ebuild to 0.23.5 and, despite a good number of warnings, it builds successfully.

Reproducible: Always
Comment 1 Tommaso Pasini 2010-02-25 10:23:45 UTC 
Created attachment 221105 [details]
vte-0.22.5 build log
Comment 2 Tommaso Pasini 2010-02-25 10:32:08 UTC 
Created attachment 221109 [details]
vte-0.23.5 build log with all the warnings

Looking at the configure script the only difference in dependencies is about glib, previously >=2.18.0 and now >=2.22.0.
Comment 3 Priit Laes (IRC: plaes) 2010-02-26 09:42:55 UTC 
Pushed x11-libs/vte-0.23.5 to tree, so this should fix it.
Comment 4 Tommaso Pasini 2010-02-27 10:35:58 UTC 
The bug happens also with vte-0.22.5 against gtk+-2.19.6, vte-0.23.5 builds fine.
Comment 5 Nirbheek Chauhan (RETIRED) gentoo-dev 2010-02-28 07:11:16 UTC 
Since vte-0.23.5 has been added to overlay, marking this as FIXED.
Comment 6 Mart Raudsepp gentoo-dev 2010-03-14 22:52:57 UTC 
What was the exact problem that the newer VTE now fixed? I'm worried about API compatibility of gtk+ here
Comment 7 Priit Laes (IRC: plaes) 2010-03-15 06:00:53 UTC 
(In reply to comment #6)
> What was the exact problem that the newer VTE now fixed? I'm worried about API
> compatibility of gtk+ here
> 

The problem was that after bumping gtk+ in the tree, vte-0.22.5 didn't build anymore because it was using deprecated functionality. 

ABI didn't seem to be changed.
Comment 8 Mart Raudsepp gentoo-dev 2010-03-15 06:09:08 UTC 
So it fails to compile only because VTE development versions are being compiled with G_DISABLE_DEPRECATED (as intended)? But then vte-0.22 wouldn't have failed.
So basically you are confirming that this is an API break in gtk+? GTK+ has to provide not only ABI backwards compatibility across 2.x series, but also API
Comment 9 Juergen Rose 2010-04-05 13:06:57 UTC 
It fails also with gtk+-2.20.0.
Comment 10 Juergen Rose 2010-04-05 13:08:39 UTC 
In which overlay can vte-0.23.5 be found?
Comment 11 Tommaso Pasini 2010-04-05 13:37:52 UTC 
Gnome overlay. You can find vte-0.24 there, too.
Comment 12 Matthias Schwarzott gentoo-dev 2010-05-16 17:56:50 UTC 
I think this is not fixed, if ~arch x11-libs/vte does not compile against ~arch x11-libs/gtk+ from main portage tree.
Comment 13 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-05-17 06:36:43 UTC 
>=gtk-2.19 is not ~arch, it's overlay.