Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 305313 - please add noconfigs (like nosamples) USE flag for asterisk
Summary: please add noconfigs (like nosamples) USE flag for asterisk
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Tony Vroon (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-15 21:28 UTC by michael higgins
Modified: 2010-05-13 14:51 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
this just wraps the config installation with if noconfigs .. else (asterisk_1.6.14_ebuild.patch,2.09 KB, patch)
2010-02-15 21:32 UTC, michael higgins
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description michael higgins 2010-02-15 21:28:26 UTC
Well, I guess no one is happy with either dumping unused configs into a nicely cleaned up folder, nor with having to make them as needed. How about a flag to change the behavior?

I have only a few config files. Every update to asterisk, I get a new batch of the full complement. Which means rm ./*  and restore from backup.

So I just wrapped the install routines with a use flag. I'll attach the diff.

Reproducible: Always

Steps to Reproduce:
1. clean up /etc/asterisk to remove unused config files
2. re-install


Actual Results:  
would be nice to have only those files I want in there, but all that cruft returns.

Expected Results:  
Just forget the new config files, which are basically the documentation for the options anyway.

yeah, so here's some of what happened with my patch:
--- !mtime   obj /etc/asterisk/asterisk.conf
--- !found   obj /etc/asterisk/asterisk.adsi
--- !mtime   obj /etc/asterisk/amd.conf
--- !mtime   obj /etc/asterisk/alsa.conf
--- !found   obj /etc/asterisk/alarmreceiver.conf
--- !found   obj /etc/asterisk/ais.conf
--- !found   obj /etc/asterisk/agents.conf
--- !found   obj /etc/asterisk/adtranvofr.conf
--- !found   obj /etc/asterisk/adsi.conf

IDK what is throwing that, but probably is not a problem. The build doesn't fail anyway. Diff to ebuild coming.
Comment 1 michael higgins 2010-02-15 21:32:52 UTC
Created attachment 219817 [details, diff]
this just wraps the config installation with if noconfigs .. else
Comment 2 Tony Vroon (RETIRED) gentoo-dev 2010-05-13 14:51:57 UTC
This behaviour will now cease if the samples USE-flag (which defaults to on) is unset. /etc/asterisk will not be touched any longer. This avoids adding new USE-flags, and also avoids the use of "no" USE-flags which has been discouraged for a long time.
Thank you for your bug report :)


+*asterisk-1.6.2.7 (13 May 2010)
+
+  13 May 2010; <chainsaw@gentoo.org> +asterisk-1.6.2.7.ebuild,
+  +files/1.6.2/asterisk-1.6.2.7-gsm-pic.patch,
+  +files/1.6.2/asterisk-1.6.2.7-pri-missing-keyword.patch, metadata.xml:
+  Bugfix release from upstream, closes bug #318535 by Thomas Stein. Many
+  thanks to Oliver Jaksch for his patch rediffing & scavenging activities.
+  /etc/asterisk will no longer be polluted with any sample files if the
+  samples USE-flag is unset, closes bug #286574 by Jeremy Johnson and bug
+  #305313 by Michael Higgins.