Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 304431 - version bump: dev-db/virtuoso-*-6.1.1 was: dev-db/virtuoso-*-6.1.0 fails to compile with openssl 1.0.0
Summary: version bump: dev-db/virtuoso-*-6.1.1 was: dev-db/virtuoso-*-6.1.0 fails to c...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Maciej Mrozowski
URL: http://www.themes.freshmeat.net/proje...
Whiteboard:
Keywords:
Depends on:
Blocks: openssl-1
  Show dependency tree
 
Reported: 2010-02-10 22:31 UTC by Hanno Böck
Modified: 2010-04-06 18:53 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
virtuoso-opensource-6.1.0-openssl-1.0.0-1.diff (virtuoso-opensource-6.1.0-openssl-1.0.0-1.diff,953 bytes, patch)
2010-02-10 22:56 UTC, Hanno Böck
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hanno Böck gentoo-dev 2010-02-10 22:31:13 UTC
See compiler error below.

libdk1t_la-Dkbasket.lo `test -f 'Dkbasket.c' || echo './'`Dkbasket.c                                         
Dkernel.c: In function 'PrpcConnect2':                                                                       
Dkernel.c:4284: warning: initialization discards qualifiers from pointer target type                         
Dkernel.c: In function 'ssl_server_init':                                                                    
Dkernel.c:4845: warning: assignment discards qualifiers from pointer target type                             
Dkernel.c:4895: error: 'STACK' undeclared (first use in this function)                                       
Dkernel.c:4895: error: (Each undeclared identifier is reported only once                                     
Dkernel.c:4895: error: for each function it appears in.)                                                     
Dkernel.c:4895: error: expected expression before ')' token                                                  
Dkernel.c:4897: error: expected expression before ')' token                                                  
Dkernel.c:4900: error: expected expression before ')' token                                                  
Dkernel.c:4900: error: too few arguments to function 'sk_value'                                              
Dkernel.c: In function 'PEM_parse':                                                                          
Dkernel.c:5005: warning: value computed is not used                                                          
Dkernel.c: In function 'ssl_client_use_pkcs12':                                                              
Dkernel.c:5065: error: 'STACK' undeclared (first use in this function)                                       
Dkernel.c:5065: error: expected expression before ')' token                                                  
Dkernel.c:5065: error: too few arguments to function 'sk_pop_free'                                           
Dkernel.c:5074: error: expected expression before ')' token                                                  
Dkernel.c:5074: error: too few arguments to function 'sk_pop_free'                                           
Dkernel.c:5081: error: expected expression before ')' token                                                  
Dkernel.c:5081: error: too few arguments to function 'sk_pop_free'                                           
Dkernel.c:5088: error: expected expression before ')' token                                                  
Dkernel.c:5088: error: too few arguments to function 'sk_pop_free'                                           
Dkernel.c:5091: error: expected expression before ')' token                                                  
Dkernel.c:5093: error: expected expression before ')' token                                                  
Dkernel.c:5093: error: too few arguments to function 'sk_value'                                              
Dkernel.c:5097: error: expected expression before ')' token                                                  
Dkernel.c:5097: error: too few arguments to function 'sk_pop_free'
Comment 1 Hanno Böck gentoo-dev 2010-02-10 22:56:11 UTC
Created attachment 219165 [details, diff]
virtuoso-opensource-6.1.0-openssl-1.0.0-1.diff

After a quick workaround patch, I still get an error, but it doesn't look like an openssl error, so it's probably another issue.

=====================================================================
=  STARTED RDF Mappers PACKAGING                                     
=  Wed Feb 10 23:48:59 CET 2010                                      
=====================================================================

***ABORTED: RDF Mappers PACKAGING, isql is not available
Comment 2 Daniel Black (RETIRED) gentoo-dev 2010-03-20 22:11:20 UTC
fyi I reported this upstream.
Comment 3 Maciej Mrozowski gentoo-dev 2010-03-21 13:54:33 UTC
Thanks

Yes, isql is (unfortunately) provided by unixODBC, so to avoid name clash, I rename the one from Virtuoso to isql-v which may confuse test suite.

You can export following variables in env you run tests from (if outside of portage):
export ISQL=<path_to>/isql-v
export SERVER=<path_to>/virtuoso-t

I've updated description as this bug affects virtuoso-odbc and virtuoso-server
Comment 4 Patrick van Kleef 2010-03-22 13:39:18 UTC
This is not the right way to fix this issue and i would not advice you to continue using this patch. The problem is that this code uses old sk_* function names whereas we should be using the new sk_X509_ALGOR_* macros. This solves the build issue on openssl 1.0.0 (where they indeed renamed STACK to _STACK) and is fully compatible with openssl 0.9.[78] which is what every distro is currently using.

It will be fixed in the upcoming 6.1.1 release of VOS.
Comment 5 Maciej Mrozowski gentoo-dev 2010-03-22 15:02:50 UTC
Thanks for feedback.

FYI we're not using this patch yet, it's just a preparation for openssl-1 arrival.
I'll wait for sk_* macros to appear in CVS.
Comment 6 Daniel Black (RETIRED) gentoo-dev 2010-04-05 09:34:14 UTC
Maciej - 6.1.1 released
Comment 7 Maciej Mrozowski gentoo-dev 2010-04-06 18:53:24 UTC
6.1.1 in tree, thanks