Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 303395 - net-analyzer/flow-tools-0.68-r6 broken due to bad patch from bug #213788
Summary: net-analyzer/flow-tools-0.68-r6 broken due to bad patch from bug #213788
Status: RESOLVED DUPLICATE of bug 213788
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-03 22:50 UTC by Mike Nerone
Modified: 2010-02-03 23:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Nerone 2010-02-03 22:50:37 UTC
Bug #213788 resulted in a new patch being applied to flow-export in the flow-tools ebuild with a revbump to net-analyzer/flow-tools-0.68-r6. I believe the patch was unnecessary and indeed breaks flow-export:

A. Looking at the code prior to the patch, db_tmp was the variable name containing the port number from the command line as a string. db_port then gets the port converted to an integer. Validating db_tmp, the string, was perfectly valid.

B. After the patch, the code is truly broken: the line "db_port = atoi(db_tmp);" remains, but the line where db_tmp is set before that is removed, so its value is uninitialized.

C. Further evidence: I'm running the original, unpatched code on an Ubuntu box and it works fine (inserting into MySQL, incidentally - haven't tested PostgreSQL, though we do plan to switch to it before going into production).

Full disclosure: I haven't actually tested what I'm saying on Gentoo, but just glancing at the code it seems inescapable.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2010-02-03 23:17:12 UTC
Don't CC when you can't set the Assignee, please.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2010-02-03 23:18:01 UTC

*** This bug has been marked as a duplicate of bug 213788 ***