Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 301055 - media-video/x264-encoder ebuild needs updating for new dependencies
Summary: media-video/x264-encoder ebuild needs updating for new dependencies
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: InOverlay
Depends on: 358015
Blocks:
  Show dependency tree
 
Reported: 2010-01-15 05:24 UTC by darkshikari
Modified: 2011-09-03 18:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch, works fine for me (x264-encoder-9999.ebuild.patch,1.82 KB, patch)
2011-09-03 14:32 UTC, Nikoli
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description darkshikari 2010-01-15 05:24:51 UTC
x264 recently receive useful some new features ( http://git.videolan.org/?p=x264.git;a=commit;h=8b9dcd8d50be201f1bedc9b19331432969f37d98 ) that affect dependencies for the x264-encoder package.  Specifically, there are two new optional-but-recommended dependencies:

1) FFMS2, an open source library for opening, indexing, and decoding video files.  Can be found at http://ffmpegsource.googlecode.com/ .  Builds pretty easily using cmake.
2) LAVF input, aka Lib(avformat|avcodec|swscale).  Already part of Gentoo in the form of ffmpeg.

The former is preferred by upstream due to being more reliable, while the latter is primarily intended as fallback for cases where FFMS2 can't be used, such as piped input.

Note that since FFMS2 is a frontend for ffmpeg, it still requires the same libraries that LAVF does, just indirectly.

Thus, in the next x264 package version bump, it would be preferable to have USE flags for these new features and ideally an ebuild for FFMS2 as well.

Reproducible: Always

Steps to Reproduce:
Comment 1 oman1 2010-05-06 03:12:21 UTC
x264-encoder makes a call in:
mp4.c:(.text+0x8cf): undefined reference to `gf_isom_set_pixel_aspect_ratio'

This is fixed by setting a depend for >=gpac-0.45-r1:

RDEPEND="mp4? ( >=media-video/gpac-0.4.1_pre20060122 )
        ~media-libs/x264-${PV}
        >=media-video/gpac-0.4.5-r1
        ffmpeg? ( media-video/ffmpeg )"
Comment 2 Nikoli 2011-09-03 14:32:30 UTC
Created attachment 285425 [details, diff]
patch, works fine for me
Comment 3 Nikoli 2011-09-03 14:33:16 UTC
Patched ebuild is in multimedia overlay now.
Comment 4 Maxim Koltsov (RETIRED) gentoo-dev 2011-09-03 18:32:47 UTC
Fixed to tree, thanks.