Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 300515 - media-libs/dumb: fails with forced --as-needed
Summary: media-libs/dumb: fails with forced --as-needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Christian Birchinger (RETIRED)
URL: http://www.gentoo.org/proj/en/qa/asne...
Whiteboard:
Keywords:
Depends on:
Blocks: as-needed
  Show dependency tree
 
Reported: 2010-01-11 00:34 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2010-01-14 06:51 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
adding epatch to ebuild (dumb-0.9.3-r1.diff,365 bytes, patch)
2010-01-11 12:54 UTC, Kacper Kowalik (Xarthisius) (RETIRED)
Details | Diff
fixing as-needed issues (dumb-0.9.3-as-needed.patch,591 bytes, patch)
2010-01-11 12:55 UTC, Kacper Kowalik (Xarthisius) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-01-11 00:34:18 UTC
I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Please note that this bug _might_ apply to -Wl,--as-needed in LDFLAGS as well; in both cases it should be fixed. Also, if this is due to the package in question not respecting user-defined LDFLAGS, you should get to fix that too.

Check the attached build log.

Thanks,
Diego
Comment 1 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2010-01-11 12:31:11 UTC
Diego could you attach log please? It compiles fine for me...
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-01-11 12:43:37 UTC
Sorry it compiles fine but it doesn't link -lm (it's passed before $^ which is the list of object files to link together), and the stuff that uses dumb will then be failing.
Comment 3 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2010-01-11 12:54:56 UTC
Created attachment 216064 [details, diff]
adding epatch to ebuild
Comment 4 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2010-01-11 12:55:21 UTC
Created attachment 216065 [details, diff]
fixing as-needed issues

also made it respect user LDFLAGS
Comment 5 Christian Birchinger (RETIRED) gentoo-dev 2010-01-14 05:48:29 UTC
I've added the patch. Thanks for your help.
Comment 6 Christian Birchinger (RETIRED) gentoo-dev 2010-01-14 06:51:42 UTC
I unified the PIC and the as-needed patch now, as the PIC patch is the one which adds -lm before the objects and brings in the as-needed problem that way.

Also made the patch usefull for dumb and aldumb (has no maintainer) because they
already share the same source archive anyway.