Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 299970 - app-portage/gentoolkit-0.3.0_rc8 dropped keywords due to app-misc/realpath runtime dependency
Summary: app-portage/gentoolkit-0.3.0_rc8 dropped keywords due to app-misc/realpath ru...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords: KEYWORDREQ
Depends on:
Blocks: 237964 305793
  Show dependency tree
 
Reported: 2010-01-06 23:11 UTC by Paul Varner (RETIRED)
Modified: 2010-04-27 10:15 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Varner (RETIRED) gentoo-dev 2010-01-06 23:11:34 UTC
I have dropped the following keywords from gentoolkit-0.3.0_rc8 due to the runtime dependency on app-misc/realpath for revdep-rebuild:

~m68k ~s390 ~sh ~sparc-fbsd ~x86-fbsd

m68k/s390/sh: Can you please test and keyword app-misc/realpath with revdep-rebuild and re-keyword gentoolkit-0.3.0_rc8?

bsd: Can you please verify that revdep-rebuild works with the realpath binary in freebsd-bin, so that we can make the appropriate dependency changes and re-keyword gentoolkit-0.3.0_rc8?
Comment 1 Paul Varner (RETIRED) gentoo-dev 2010-02-18 18:25:00 UTC
We are also going to need this for gentoolkit-0.2.4.6 which is gentoolkit-0.2.4.5 with all fixes to revdep-rebuild from the gentoolkit-0.3.0 series backported.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2010-02-24 17:47:56 UTC
How does it use realpath, and why can't it use `readlink -f' (coreutils) instead?
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-02-24 17:54:50 UTC
readlink -f and realpath have slightly different semantics, and readlink -f is not compatible with non-GNU systems.
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2010-02-24 18:03:01 UTC
Yes, I gathered as much, but with slightly more complicated code (I think it's only used in revdep-rebuild anyway) to check whether to use either realpath or readlink, an RDEPEND could be dropped for everything GNU. Want another bug opened with perhaps a patch?
Comment 5 Paul Varner (RETIRED) gentoo-dev 2010-02-24 21:05:12 UTC
I'm always open to patches and suggestions.  

Personally, I liked realpath because it is compatible to non-GNU systems.  But if ongoing maintenance and architecture keywording/stabilization will be easier by using readlink -f, then let's go that route.  

My only concern with changing it right now is that the realpath changes have been tested fairly well on the gentoolkit-0.3.0 series and I would like to request 0.2.4.6 stable as soon as it hits 30 days in tree.  The revdep-rebuild in 0.2.4.5 is going to start causing major problems as some of the packages currently in ~arch start going stable.

However, since realpath isn't keyworded on the architectures CC'ed in this bug, for them that is a moot point and we could target 0.2.4.7 with readlink -f/realpath for those architectures.
Comment 6 Raúl Porcel (RETIRED) gentoo-dev 2010-04-01 17:20:12 UTC
~m68k/~s390/~sh done
Comment 7 Alexis Ballier gentoo-dev 2010-04-27 10:15:33 UTC
seems fine with realpath from fbsd-bin, dep adjusted and keyworded *-fbsd -> fixed