Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 296952 - media-video/mpeg-tools: pre-stripped files found
Summary: media-video/mpeg-tools: pre-stripped files found
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: prestripped
  Show dependency tree
 
Reported: 2009-12-14 22:12 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2010-02-04 23:48 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (mpeg-tools-1.5b-r3:20091214-161837.log,26.09 KB, text/plain)
2009-12-14 22:12 UTC, Diego Elio Pettenò (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2009-12-14 22:12:39 UTC
Portage warns about pre-stripped files being installed into the image directory; this is a bad thing since it makes Portage's splitdebug feature useless, and it stops the users and the developers from looking into backtraces with full debug information available.

For the developers going to look into it, what you have to look out for, to
find what is stripping the files, is one of these conditions:

- explicit "strip" command run on the produced files;
- "install -s" command to install the binary files;
- "-Wl,-s" flag passed during linking

Remove the "strip" commands, remove the "-s" option at install, and remove
"-Wl,-s" and the problem should be gone.

For what concerns pre-built packages, you should set the QA_PRESTRIPPED variable in the ebuild with the list of known pre-stripped objects in the package.

Thanks,
Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-12-14 22:12:59 UTC
Created attachment 213040 [details]
Build log
Comment 2 Kevin Pyle 2009-12-15 06:00:16 UTC
The target for mpeg_encode, at Makefile:205, explicitly strips mpeg_encode after building it.  Even worse, they do not use a qualified name for strip, so it may fail to strip properly when cross-compiled.  Deleting the explicit strip at line 207 should fix the QA problem.
Comment 3 Justin Lecher (RETIRED) gentoo-dev 2010-02-04 23:48:21 UTC
Thanks Kevin for the hint.