Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 296050 - dev-libs/iniparser-3.0b-r1 ignores CC
Summary: dev-libs/iniparser-3.0b-r1 ignores CC
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Gentoo's SAMBA Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-07 05:42 UTC by Jeroen Roovers (RETIRED)
Modified: 2010-04-11 08:25 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to respect CC and AR properly, various other QA stuff (iniparser-3.0b-r1.ebuild.patch,1.36 KB, patch)
2009-12-07 05:46 UTC, Jeroen Roovers (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2009-12-07 05:42:22 UTC
Patch coming.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2009-12-07 05:46:40 UTC
Created attachment 212299 [details, diff]
Patch to respect CC and AR properly, various other QA stuff

* No need to pass CC and AR to emake (or indeed inherit eutils).
* Comment both out in Makefile instead.
* Move sed to src_unpack() (could have picked src_prepare() too).
* Remove unused (R)DEPEND.

src_test() should be written to not only build test/parse but execute and check its return code as well. There's a CC/LDFLAGS ignorance problem there that I didn't go and fix. Basically both Makefiles suck and the sed scripts should probably be rewritten as a patch. :)
Comment 2 Tiziano Müller (RETIRED) gentoo-dev 2010-04-11 08:25:46 UTC
I wrote a patch for the makefile instead, moved to EAPI=2, disabled tests (since those are rather examples) and install tests as examples.
Thanks.