294749 – dev-dotnet/pe-format init.d script uses bashisms

Bug 294749 - dev-dotnet/pe-format init.d script uses bashisms

Summary: dev-dotnet/pe-format init.d script uses bashisms

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	High trivial (vote)
Assignee:	dotnet project

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2009-11-26 19:40 UTC by Michał Górny
Modified:	2010-09-12 17:47 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
patch for pe-format.init (pe-format.init.patch,1000 bytes, patch) 2010-08-25 10:29 UTC, Mu Qiao (RETIRED)	Details \| Diff
patch for pe-format.init-1 (pe-format.init-1.patch,1006 bytes, patch) 2010-08-25 10:30 UTC, Mu Qiao (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2009-11-26 19:40:04 UTC

Init.d script installed with dev-dotnet/pe-format uses unnecessary bashisms while OpenRC launches init.d scripts with /bin/sh. This makes the script unusable on setups with non-bash default shell.

AFAICS, the only needed change is to replace [[ ]] tests with [ ] ones.

Comment 1 Mu Qiao (RETIRED) gentoo-dev

2010-08-25 10:29:51 UTC

Created attachment 244501 [details, diff]
patch for pe-format.init

I guess this patch could fix pe-format.init

Comment 2 Mu Qiao (RETIRED) gentoo-dev

2010-08-25 10:30:37 UTC

Created attachment 244503 [details, diff]
patch for pe-format.init-1

I guess this could fix pe-format.init-1

Comment 3 William Hubbs gentoo-dev

2010-09-06 20:38:08 UTC

This does need to be fixed; however, init.d scripts that are not posix compliant do not block openrc stabilization.

Comment 4 Pacho Ramos gentoo-dev

2010-09-12 17:47:36 UTC

+*pe-format-2.0.3 (12 Sep 2010)
+
+  12 Sep 2010; Pacho Ramos <pacho@gentoo.org> +pe-format-2.0.3.ebuild,
+  metadata.xml:
+  Version bump with a new upstream, new proxy maintainer and fixing old bugs
+  #246456, #29795 (for support more exe files), #294749 (stop using bashisms
+  and adapt script to openrc), #321233 (pe-format2 is now pe-format). Really
+  thanks a lot to Michał Górny for taking care of this package.
+