Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 293002 - app-portage/gentoolkit-0.2.4.5: "eclean -d distfiles" removes too much files
Summary: app-portage/gentoolkit-0.2.4.5: "eclean -d distfiles" removes too much files
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 237964
  Show dependency tree
 
Reported: 2009-11-13 09:30 UTC by Toralf Förster
Modified: 2010-04-06 20:35 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
use rm -f for non-interactive temp file removal (rr_noninterative_rm.patch,450 bytes, patch)
2010-02-01 05:27 UTC, Douglas Anderson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2009-11-13 09:30:57 UTC
Today kdiff3-0.9.92.tar.gz was removed from the distdir althought the corresponding package is installed : 

n22 ~ # equery l kdiff3
[ Searching for package 'kdiff3' in all categories among: ]
 * installed packages
[I--] [M ] kde-misc/kdiff3-0.9.92 (0)


Reproducible: Always



Expected Results:  
eclean should leave the tar.gz file for installed packages
Comment 1 Douglas Anderson 2010-02-01 05:27:42 UTC
Created attachment 218053 [details, diff]
use rm -f for non-interactive temp file removal

Couldn't reproduce this bug in 0.3.0_rc8, but glancing through the source, I did notice only one instance where temp files were removed with rm, where in all other locations we're using rm -f. So this patch should fix the bug, though not sure if it really fixes the root of the issue.

Also fixed in genscripts svn:
$ svn ci -m "Fixes an issue in revdep-rebuild where we were using 'rm file' instead of 'rm -f file' for non-interactive removing of temp files; bug #284419"
Sending        bin/revdep-rebuild
Transmitting file data .
Committed revision 184.
Comment 2 Douglas Anderson 2010-02-01 05:30:59 UTC
That'll teach me not to work on two bugs at once. Disregard the previous comment. Sorry for the spam.
Comment 3 Brian Dolbec (RETIRED) gentoo-dev 2010-03-06 19:58:58 UTC
That happens due to a shortcoming of the search portion of the logic.  It did not account for deprecated installed packages.  I discovered and have fixed this already in the modular eclean re-write.  You should see the fixed version in the gentoolkit-0.3.0_rc10 and later releases.  It also has other improvements and bugfixes to the code.