Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 291919 - [patch] make tiff dependency optional for x11-libs/wxGTK
Summary: [patch] make tiff dependency optional for x11-libs/wxGTK
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo wxWidgets project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-04 21:49 UTC by Wouter
Modified: 2010-05-27 05:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to make media-libs/tiff optional (wxGTK_libtiff.patch,899 bytes, patch)
2009-11-04 21:51 UTC, Wouter
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wouter 2009-11-04 21:49:29 UTC
I don't really see a reason why this should not be optional. Its what Gentoo is all about after all. :)

Reproducible: Always

Steps to Reproduce:
1. USE=-tiff emerge x11-libs/wxGTK
Comment 1 Wouter 2009-11-04 21:51:10 UTC
Created attachment 209279 [details, diff]
patch to make media-libs/tiff optional
Comment 2 Ryan Hill (RETIRED) gentoo-dev 2009-11-10 00:38:09 UTC
i tried making it optional a couple years ago and remember many packages breaking.  i guess we have USE deps now, but every wxGTK-using ebuild in the tree would have to be tested first.  and if enough require it that it's going to nearly always need to be enabled anyways then i'm reluctant to make it an option.

but, i'll look into it again.
Comment 3 Wouter 2009-11-12 15:37:11 UTC
Good point, in that case, would it be possible to make it a default using the +<flag> notation in the IUSE? That way it will not break things by just upgrading and still allows people to disable it if they want to?

Then people who accidentally break packages by explicitly disabling things can tell other ebuild maintainers to add a USE dependency?

Anyways, thanks for looking into it in the first place. :)
Comment 4 Ryan Hill (RETIRED) gentoo-dev 2010-01-28 04:23:00 UTC
it looks like most of the breakage I was thinking of was from a previous request to make tiff, png, and jpeg USE flags.  disabling tiff doesn't break that much, with the big exception of wxpython (and all wxpython-using packages).  the version in my overlay adds the flag but I still need to finish testing.
Comment 5 Ryan Hill (RETIRED) gentoo-dev 2010-05-27 05:21:39 UTC
Fixed in 2.8.11.0.