Bug 291838 – dev-python/python-ptrace-0.6 should install examples, doc

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Daa Jaa 2009-11-04 13:07:45 UTC]

src_install should also do something like
  dodoc examples/ doc/

to include itrace.py and simple_dbg.py, which are referenced in /usr/share/doc/python-ptrace-0.6/ChangeLog.bz2

Reproducible: Always

Steps to Reproduce:
1. emerge '=dev-python/python-ptrace-0.6'
2. equery files python-ptrace| grep itrace.py
3.
Actual Results:  
[no match showed by grep]

Expected Results:  
/usr/share/doc/python-ptrace-0.6/examples/itrace.py

src_install should also do something like
  dodoc examples/ doc/

I do not know if dodoc is recursive on directories.

[Comment 1 Ian Delaney (RETIRED) 2011-11-21 17:51:34 UTC]

the fix

src_install() {
        dodir /usr/share/doc/${PF}/examples
        ls -ld "${ED}"usr/share/doc/${PF}/examples
        cp -R "${S}/"examples/* "${D}"/usr/share/doc/${PF}/examples

        dodoc ${DOCS[@]}
}

[Comment 2 Ian Delaney (RETIRED) 2011-11-21 19:37:47 UTC]

Created attachment 293353 [details, diff]
ebuild patch

src_install() {
        dodir usr/share/doc/${PF}/examples
        docompress -x usr/share/doc/${PF}/examples
        insinto usr/share/doc/${PF}/examples
        doins examples/* || die
#       cp -R "${S}/"examples/* "${D}"/usr/share/doc/${PF}/examples
        # dodocs is NOT redundant; DOCS defined with 1 unique entry
        dodoc ${DOCS[@]}
}
gentoo64 python-ptrace # ls /mnt/gen2/tmpdir/portage/dev-python/python-ptrace-0.6.3/image/usr/share/doc/python-ptrace-0.6.3/examples/
itrace.py  simple_dbg.py
gentoo64 python-ptrace # ls /mnt/gen2/tmpdir/portage/dev-python/python-ptrace-0.6.3/image/usr/share/doc/python-ptrace-0.6.3/         
AUTHORS.bz2  PKG-INFO.bz2  README.bz2  README.cptrace.bz2  TODO.bz2  examples
gentoo64 python-ptrace #

[Comment 3 Ian Delaney (RETIRED) 2011-11-21 21:07:51 UTC]

Created attachment 293365 [details, diff]
revised ebuild patch

[Comment 4 Ian Delaney (RETIRED) 2011-11-21 21:21:18 UTC]

Created attachment 293367 [details, diff]
revised ebuild patch

[Comment 5 Ian Delaney (RETIRED) 2011-11-21 21:30:10 UTC]

Created attachment 293369 [details, diff]
revised ebuild patch

[Comment 6 Arfrever Frehtes Taifersar Arahesis 2011-11-21 21:33:04 UTC]

(In reply to comment #5)

This patch is for already modified ebuild.
PKG-INFO is not documentation. It shouldn't be added to DOCS variable.

[Comment 7 Ian Delaney (RETIRED) 2011-11-22 17:55:33 UTC]

Created attachment 293423 [details, diff]
revised ebuild patch

removed it as prompted, has scripts requiring python_convert_shebangs

[Comment 8 Arfrever Frehtes Taifersar Arahesis 2011-11-22 19:01:42 UTC]

(In reply to comment #7)

Scripts installed by this package already have correct shebangs.
Also this package supports Python 3.