This is wrong because it will still build xfce4-tips binary at compile-time, if ! use fortune; then # Wipe away unusable xfce4-tips rm -Rf "${D}"/usr/share/xfce4/tips rm -f "${D}"/usr/bin/xfce4-tips \ "${D}"/usr/lib/debug/usr/bin/xfce4-tips.debug \ "${D}"/etc/xdg/autostart/xfce4-tips-autostart.desktop rmdir -p "${D}"/etc/xdg/autostart fi It must be converted to upstream suitable patch for "./configure --disable-tips" flag to work.
And we also have policy to report everything upstream, http://bugzilla.xfce.org/ or otherwise the change will be dropped in next revision. This is no exception.
Created attachment 208145 [details, diff] Add --{en,dis}able-tips configure options First candidate on a patch.
Did you take this patch upstream already, Sebastian?
(In reply to comment #3) > Did you take this patch upstream already, Sebastian? No, I assumed Samuli would do that. Feel free to take it upstream.
(In reply to comment #4) > (In reply to comment #3) > > Did you take this patch upstream already, Sebastian? > > No, I assumed Samuli would do that. Feel free to take it upstream. > Sebastian, please don't patch anything else in gentoo for xfce if you are not willing to take it upstream. Thanks in advance.
Jeremy, I wrote the patch to take work off you guys shoulders. To me the original solution was perfectly adequate. I'm busy with more important stuff, Gentoo things included. I'm not shy of co-op with upstream at all.
(In reply to comment #6) > Jeremy, I wrote the patch to take work off you guys shoulders. To me the > original solution was perfectly adequate. I'm busy with more important stuff, > Gentoo things included. I'm not shy of co-op with upstream at all. > I realized that you are too busy with more important things. As such, I just asked you to not mess with xfce in the future. Thanks.
http://bugzilla.xfce.org/show_bug.cgi?id=6525
