Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 289580 - net-wireless/wireless-tools-29 redefines "inline" in a public header
Summary: net-wireless/wireless-tools-29 redefines "inline" in a public header
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: PPC Linux
: High normal with 1 vote (vote)
Assignee: Mobile Herd (OBSOLETE)
URL: https://bugs.launchpad.net/ubuntu/+so...
Whiteboard:
Keywords:
: 301874 329601 345967 349836 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-10-18 13:32 UTC by Andrea Conti
Modified: 2011-04-11 04:09 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch based on 30_pre9 (wireless-tools-29-inline-fix.patch,3.61 KB, patch)
2011-03-05 21:55 UTC, Joe Jezak (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrea Conti 2009-10-18 13:32:46 UTC
net-wireless/wireless-tools-29 installs a public header (/usr/include/iwlib.h) which redefines "inline" with a macro on certain GCC versions, including all 4.X.

This breaks at least xulrunner on ppc32; other packages might be affected (see the launchpad URL for details).

xulrunner-1.9.1.3 is surely affected; I have not tried older versions.

Ubuntu patch for this problem is at http://launchpadlibrarian.net/32363867/wireless-tools_29-2ubuntu5_29-2ubuntu6.diff.gz

Reproducible: Always

Steps to Reproduce:
1. emerge =net-wireless/wireless-tools-29
2. emerge =net-libs/xulrunner-1.9.1.3

Actual Results:  
The actual error:

[...]

powerpc-unknown-linux-gnu-g++ -o nsWifiScannerUnix.o -c -fvisibility=hidden -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_COM_OBSOLETE -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux -DIMPL_NS_NET  -I. -I. -I../../../dist/include/xpcom -I../../../dist/include/string -I../../../dist/include/pref -I../../../dist/include/storage -I../../../dist/include   -I../../../dist/include/necko -I/usr/include/nspr    -I/var/tmp/portage/net-libs/xulrunner-1.9.1.3/work/mozilla-1.9.1/dist/sdk/include    -fPIC   -fno-rtti -fno-handle-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -mcpu=7450 -pipe -mabi=altivec -fno-strict-aliasing -Wno-return-type -w -fno-strict-aliasing -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -Os -freorder-blocks -fno-reorder-functions    -DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/nsWifiScannerUnix.pp nsWifiScannerUnix.cpp
In file included from /usr/lib/gcc/powerpc-unknown-linux-gnu/4.4.2/include/g++-v4/cstddef:44,
                 from /usr/lib/gcc/powerpc-unknown-linux-gnu/4.4.2/include/g++-v4/new:40,
                 from ../../../dist/include/xpcom/nsTArray.h:47,
                 from ../../../dist/include/string/nsReadableUtils.h:52,
                 from ../../../dist/include/string/nsString.h:53,
                 from ../../../dist/include/xpcom/nsStringGlue.h:50,
                 from ../../../dist/include/xpcom/nsVoidArray.h:44,
                 from ../../../dist/include/xpcom/nsCOMArray.h:43,
                 from nsWifiMonitor.h:47,
                 from nsWifiScannerUnix.cpp:46:
/usr/lib/gcc/powerpc-unknown-linux-gnu/4.4.2/include/g++-v4/powerpc-unknown-linux-gnu/bits/c++config.h:214: error: expected unqualified-id before 'namespace'
gmake[5]: *** [nsWifiScannerUnix.o] Error 1

I am not attaching the complete build log as I don't think it is needed. If it is, just ask.


emerge --info output:

System uname: Linux-2.6.31-gentoo-r3-ppc-7447A,_altivec_supported-with-gentoo-2.0.1
Portage 2.1.7.1 (default/linux/powerpc/ppc32/10.0/desktop, gcc-4.4.2, glibc-2.9_p20081201-r3, 2.6.31-gentoo-r3 ppc)
=================================================================
System uname: Linux-2.6.31-gentoo-r3-ppc-7447A,_altivec_supported-with-gentoo-2.0.1
Timestamp of tree: Sun, 18 Oct 2009 08:45:03 +0000
distcc 3.1 powerpc-unknown-linux-gnu [enabled]
ccache version 2.4 [enabled]
app-shells/bash:     4.0_p33
dev-java/java-config: 2.1.9-r1
dev-lang/python:     2.6.3, 3.1.1-r1
dev-util/ccache:     2.4-r8
dev-util/cmake:      2.6.4-r2
sys-apps/baselayout: 2.0.1
sys-apps/openrc:     0.5.1-r1
sys-apps/sandbox:    2.1
sys-devel/autoconf:  2.13, 2.63-r1
sys-devel/automake:  1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.2, 1.11
sys-devel/binutils:  2.19.1-r1
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.6a
virtual/os-headers:  2.6.30-r1
ACCEPT_KEYWORDS="ppc ~ppc"
CBUILD="powerpc-unknown-linux-gnu"
CFLAGS="-mcpu=7450 -O2 -pipe -maltivec -mabi=altivec -fno-strict-aliasing"
CHOST="powerpc-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc
/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-mcpu=7450 -O2 -pipe -maltivec -mabi=altivec -fno-strict-aliasing"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests buildpkg ccache distcc distlocks fixpackages news parallel-fetch protect-owned sandbox sfperms strict unmer
ge-logs unmerge-orphans userfetch"
GENTOO_MIRRORS="http://mirror.switch.ch/ftp/mirror/gentoo http://ftp.heanet.ie/pub/gentoo http://gentoo.osuosl.org http://www.ibibli
o.org/Linux/distributions/gentoo"
LDFLAGS="-Wl,-O1"
LINGUAS="en"
MAKEOPTS="-j5"
PKGDIR="/usr/portage-packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats
 --timeout=180 --exclude='/distfiles' --exclude='/local' --exclude='/packages' --progress"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage /usr/local/portage-shared"
SYNC="rsync://portage.agr.fm/gentoo-portage"
USE="X a52 aac alsa altivec bluetooth branding bzip2 cairo cdr cli consolekit cracklib crypt cups dbus dri dts dvd dvdr eds emboss e
ncode evo fam firefox flac fortran gif gpm gstreamer gtk hal iconv isdnlog java java6 jpeg kde libnotify logrotate mad mikmod module
s mp3 mp4 mpeg ncurses nls nptl nptlonly ogg opengl openmp pam pcre pdf perl png ppc ppds pppd python qt3support qt4 quicktime readl
ine reflection sdl session spell spl ssl startup-notification svg sysfs tcl tcpd test threads thunar tiff truetype unicode usb vorbi
s x264 xml xorg xulrunner xv xvid zlib" ALSA_CARDS="aoa aoa-fabric-layout aoa-onyx aoa-soundbus aoa-soundbus-i2s aoa-tas aoa-toonie
powermac usb-audio via82xx" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa
lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_al
ias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoinde
x cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio me
m_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEV
ICES="keyboard mouse synaptics evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses t
ext" LINGUAS="en" USERLAND="GNU" VIDEO_CARDS="nv"
Comment 1 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2009-10-20 09:12:34 UTC
wireless-tools-30_pre8 was just committed to the tree. could you try that version? thanks
Comment 2 Andrea Conti 2009-10-20 11:54:17 UTC
No, building xulrunner still fails with -30_pre8 (which is expected, as the specific section of iwlib.h that is causing the problem is still there unchanged).
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2010-07-23 16:39:53 UTC
*** Bug 329601 has been marked as a duplicate of this bug. ***
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2010-07-23 16:53:21 UTC
*** Bug 301874 has been marked as a duplicate of this bug. ***
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2010-07-23 17:13:32 UTC
(In reply to comment #4)
> *** Bug 301874 has been marked as a duplicate of this bug. ***

That bug has a patch attached that gets rid of the ridiculous compiler "fix".
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2010-07-23 17:18:46 UTC
According to...

http://packages.debian.org/changelogs/pool/main/w/wireless-tools/wireless-tools_30~pre9-5/changelog

* New upstream release.
   - Does not redefine inline keyword on recent compilers anymore.
   Closes: #548192

This bug is fixed since 30_pre9 upstream release, we have that in tree package.masked. It's the version Debian is using in 'testing', maybe we should use it in ~arch? 

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=548192
Comment 7 Jory A. Pratt gentoo-dev 2010-11-19 12:27:56 UTC
*** Bug 345967 has been marked as a duplicate of this bug. ***
Comment 8 Jory A. Pratt gentoo-dev 2010-12-28 02:26:51 UTC
*** Bug 349836 has been marked as a duplicate of this bug. ***
Comment 9 Massimo Burcheri 2011-02-08 09:04:43 UTC
Any news? This bug still breaks compiling current net-libs/xulrunner-1.9.2.13 (stable for most archs).
Should we unmask 30_pre9 and use it in ~ppc or even ppc, since current stable set around firefox does not compile on ppc?
Are other architectures affected by this bug? Otherwise please adjust Hardware: flag.
Comment 10 Joe Jezak (RETIRED) gentoo-dev 2011-03-05 21:55:07 UTC
Created attachment 264875 [details, diff]
Patch based on 30_pre9

This patch implements the same "fix" as the one in wireless-tools-30_pre9. If I don't hear any complaints about it in the next week, I'm going to just commit it, this issue has hung around for too long.
Comment 11 Alex Buell 2011-03-12 14:35:01 UTC
Compiles and installs OK, commands appear to run OK although I don't have wireless on my SPARCs. Stabilisation might be OK.
Comment 12 Joe Jezak (RETIRED) gentoo-dev 2011-04-04 06:15:13 UTC
Still no response, so I've added the fix to the tree. I'll go stable with this version on ppc/ppc64 if we don't hear back otherwise.
Comment 13 Joe Jezak (RETIRED) gentoo-dev 2011-04-11 04:09:29 UTC
Still no response, so I've marked 29-r1 ppc stable which fixes this bug.