Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 288371 - gnome-base/gnome-applets-2.26.3: stickynotes dialog boxes don't respond to input
Summary: gnome-base/gnome-applets-2.26.3: stickynotes dialog boxes don't respond to input
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
: 307145 (view as bug list)
Depends on: 314899
Blocks:
  Show dependency tree
 
Reported: 2009-10-10 00:59 UTC by Robert Trace
Modified: 2010-05-07 10:46 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Updated stickynotes.glade (stickynotes-glade.patch,41.03 KB, patch)
2009-10-10 01:02 UTC, Robert Trace
Details | Diff
Updated stickynotes.ui restores function in applet (stickynotes-ui.patch,41.71 KB, patch)
2009-10-10 01:04 UTC, Robert Trace
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Trace 2009-10-10 00:59:22 UTC
After upgrading gnome-applets from 2.24.x to (stable) 2.26.3 I noticed that I could no longer delete existing stickynotes that contained data (empty notes could still be deleted).  When presented with the "Are you sure you want to delete this note" dialog box, the "Delete" and "Cancel" buttons were both non-responsive.  Additionally, the preferences dialog box was also unresponsive to it's "Close" and "Help" buttons.

A debian user has hit this as well: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=550054

I tracked down the unresponsive delete dialog to the point where the applet runs the dialog (gnome-applets/stickynotes/stickynotes.c:722; gtk_dialog_run()) and then I lost it in gtk internals.  It seems as though the dialog box isn't ever handling it's button messages.

By dumb luck, I started playing with the interface description file and I think I found some of the solution.  I think the interface XML file is malformed/incorrect in some way and it's causing the dialogs to fail.  Running the stickynotes.glade source file though dev-util/glade-3.4.5 produced a significantly different file (attached) and the resulting XML file is also different than what ships.

Substituting this updated XML file for the original one allows stickynotes to work properly.  I'll attach a patch.


Reproducible: Always

Steps to Reproduce:
1. Create a stickynote
2. Put at least one character in it
3. Try to delete note
4. Click "Delete" button on resulting dialog and watch it ignore you.

Actual Results:  
All (both) dialog boxes seem unresponsive.

Expected Results:  
Dialog boxes should respond to their buttons.
Comment 1 Robert Trace 2009-10-10 01:02:41 UTC
Created attachment 206603 [details, diff]
Updated stickynotes.glade

After passing the shipped stickynotes.glade file straight through glade 3.4.5, this is the result.

Since the distributed tar doesn't seem to contain this file, it's only instructive to end-users. :-)
Comment 2 Robert Trace 2009-10-10 01:04:38 UTC
Created attachment 206605 [details, diff]
Updated stickynotes.ui restores function in applet

... and this is the result of passing the updated glade file (above) through gtk-builder-convert.

Patching this file into the tar distribution should restore applet functionality.
Comment 3 Romain Perier (RETIRED) gentoo-dev 2009-10-10 09:10:50 UTC
What do upstream devs think about that ?
Comment 4 Yu Yuwei 2009-10-15 17:16:31 UTC
(In reply to comment #2)
> Created an attachment (id=206605) [details]
> Updated stickynotes.ui restores function in applet
> 
> ... and this is the result of passing the updated glade file (above) through
> gtk-builder-convert.
> 
> Patching this file into the tar distribution should restore applet
> functionality.
> 

Thanks for your patch, it works  :)

Comment 5 Yu Yuwei 2009-10-15 17:19:57 UTC
preference dialog suffers the same problem :(
Comment 6 Robert Trace 2009-10-15 18:50:33 UTC
(In reply to comment #5)
> preference dialog suffers the same problem :(

Yes it does, without the patch.  The patch seems to also fix the preferences dialog on my systems.
Comment 7 Romain Perier (RETIRED) gentoo-dev 2009-10-15 21:56:48 UTC
Please ask on upstream before conclude any stuff
Comment 8 Robert Trace 2009-10-15 22:14:00 UTC
(In reply to comment #7)
> Please ask on upstream before conclude any stuff

?

I don't understand what you mean.

I looked in upstream's bugzilla and git repositories and there's no mention of this behavior.  Also, upstream probably doesn't care since they've progressed to 2.28 which removes the need to run glade interface descriptions through gtk-builder-convert (glade 3.6 can read/write the XML directly), so the XML file they have in git has been updated (and if you take their released 2.28 XML file and drop it in here, then it also fixes the problems described in this bug).
Comment 9 Romain Perier (RETIRED) gentoo-dev 2009-10-16 11:40:05 UTC
There are many different branches on their repository on upstream, there is also a branch for gnome-applets-2.26 (with a tags in this branch)
When I said "ask on upstream" I meant :

- Please open a new bug on upstream (if it does not exist yet)
- Please attach your patch to this bug as proposal
- Then paste the URL here

=> that's very important to ask upstream confirmation because they are guys who wrote this soft, so necessarily they know it better than us :)

Btw, the lastest release is may be 2.28.0 but upstream developers still maintain the previous release (2.26 in this case) at least for bugfixes ;)
Comment 10 Mart Raudsepp gentoo-dev 2009-10-18 00:11:46 UTC
They don't maintain 2.26 anymore, 2.28 is the newstable. I see no point in bothering upstream about this if it's fixed in 2.28
Comment 11 Fabio Bonfante 2009-10-31 16:34:50 UTC
very annoying bug...
tnx works for me too (just applied the stickynotes.ui patch)
Comment 12 bugzilla-gentoo 2010-01-24 21:15:53 UTC
The stickynotes-ui.patch solves the issue for me (amd64). Thanks Robert. Please include the patch in the next revision since this issue completely renders stickynotes useless.
Comment 13 Andrey Vihrov 2010-01-24 21:19:43 UTC
(In reply to comment #12)

Note that you can delete a sticky note if you first erase its content :)
Comment 14 Pacho Ramos gentoo-dev 2010-02-28 12:32:46 UTC
*** Bug 307145 has been marked as a duplicate of this bug. ***
Comment 15 Pacho Ramos gentoo-dev 2010-04-14 16:06:49 UTC
Better wait for 2.28 stabilization since:
1. Patches to backport would change a lot upstream code and, then, I think that would be safer to keep close to upstream and, then, simply stable 2.28 version as it fixes the issue.
2. Gnome 2.28 shouldn't take too long (we are working on it)

Sorry a lot for the long delay, but Gnome team is a bit overworked 

Thanks for reporting
Comment 16 Pacho Ramos gentoo-dev 2010-05-07 10:46:36 UTC
2.28 is already going stable fixing this issue