Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 287589 - sci-visualization/paraview use cmake command directly
Summary: sci-visualization/paraview use cmake command directly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High major
Assignee: Markus Dittrich (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 287583
  Show dependency tree
 
Reported: 2009-10-03 22:05 UTC by Tomáš Chvátal (RETIRED)
Modified: 2010-01-16 20:52 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild proted to cmake-utils.eclass (paraview-3.6.1-r1.ebuild,6.48 KB, text/plain)
2009-12-15 02:16 UTC, François Bissey
Details
OK ported to the newest cmake-utils eclass and with an added patch. (paraview-3.6.1-r1.ebuild,6.51 KB, text/plain)
2009-12-15 20:44 UTC, François Bissey
Details
patch for detecting nvidia-cg-toolkit on Gentoo (paraview-3.6.1-VTK-cg-path.patch,1.05 KB, patch)
2009-12-15 20:44 UTC, François Bissey
Details | Diff
fix the about.html thing patch for it following (paraview-3.6.1-r1.ebuild,6.52 KB, text/plain)
2009-12-16 08:55 UTC, François Bissey
Details
patch to avoid installing about.hml in /usr/bin (paraview-3.6.1-about.patch,517 bytes, patch)
2009-12-16 08:56 UTC, François Bissey
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomáš Chvátal (RETIRED) gentoo-dev 2009-10-03 22:05:20 UTC
Please for explanation why it is bad head for bug which block this one.

This package was anounced as broken in old bug 267776 i will mask and treeclean it in 30 days if noone step up to fix it.
Comment 1 Markus Dittrich (RETIRED) gentoo-dev 2009-10-09 01:38:27 UTC
Hi Tomáš,

PLEASE do NOT treeclean paraview just because it uses
cmake directly. Paraview as well as vtk are very complex
scientific packages which use cmake in a fairly complex
way (as a matter of fact they are both developed by
kitware which also develops cmake). Both packages
are used by a lot of people. I have not had time for 
an in depth look at the cmake-utils.eclass yet but I 
suspect quite a few of the things paraview/vtk need 
are not yet covered in the eclass at all - I might
be wrong though.

Porting paraview and vtk to the cmake.eclass is on my
to do list but will be a lot of work and require even
more testing for both of which I don't have time right now
so this will have to wait until later this year. If you have 
time to help do some of the porting work or check how 
the paraview/vtk ebuild will fit in the framework of
the eclass I'd certainly  appreciate it. 

If you have any concerns please don't hesitate to get in
touch.

Thanks,
Markus 
Comment 2 Markus Dittrich (RETIRED) gentoo-dev 2009-10-09 01:39:54 UTC
Hi Tomáš,

PLEASE do NOT treeclean paraview just because it uses
cmake directly. Paraview as well as vtk are very complex
scientific packages which use cmake in a fairly complex
way (as a matter of fact they are both developed by
kitware which also develops cmake). Both packages
are used by a lot of people. I have not had time for 
an in depth look at the cmake-utils.eclass yet but I 
suspect quite a few of the things paraview/vtk need 
are not yet covered in the eclass at all - I might
be wrong though.

Porting paraview and vtk to the cmake.eclass is on my
to do list but will be a lot of work and require even
more testing for both of which I don't have time right now
so this will have to wait until later this year. If you have 
time to help do some of the porting work or check how 
the paraview/vtk ebuild will fit in the framework of
the eclass I'd certainly  appreciate it. 

If you have any concerns please don't hesitate to get in
touch.

Thanks,
Markus
Comment 3 Markus Dittrich (RETIRED) gentoo-dev 2009-10-09 01:40:32 UTC
Sorry for the double post - bugzilla seems confused
right now.

Markus
Comment 4 Tomáš Chvátal (RETIRED) gentoo-dev 2009-10-09 11:28:21 UTC
(In reply to comment #3)
> Sorry for the double post - bugzilla seems confused
> right now.
> 
> Markus
> 

No prob :]

Well my concern is that eclass should cover everything. Cmake itself is compiled using cmake eclass. So it would be kinda weird if this two would need better treatement.

From what i can see it is easy to migrate it really. Just take look on kdelibs, they have same level of complexity, or soprano library, it uses also stupid variable names as vtk.

Cheers

Tomas
Comment 5 Markus Dittrich (RETIRED) gentoo-dev 2009-10-09 12:50:53 UTC
(In reply to comment #4)
> No prob :]
> 
> Well my concern is that eclass should cover everything. Cmake itself is
> compiled using cmake eclass. So it would be kinda weird if this two would need
> better treatement.
> 
>

You're probably right D)

Anyway, I'll promise I'll look at it as soon as I find a stretch of time
where I can dig into the eclass and make sure I don't break anything
paraview wise.

The next two months will be packed for me due to work/travel but
once that's done I should be able to give this a serious go.

Thanks for your patience.

cheers,
Markus
Comment 6 François Bissey 2009-12-14 03:12:04 UTC
Hi, 
just a quick word - as discussed with bicatali and scarabeus I am 
tackling this as a side effect of trying to get the overview application 
to really install.
I have also reworked quite a number of things in the process
[Most of those plugins now configure and compile - I just leave
you ffmpeg :) ]. I left comments all over the place it is some wild ride.
I am expecting to upload a new ebuild in the science overlay later 
tonight for general consumption, once I am sure it really works at last
and I have documented those pesky use flags.
Comment 7 François Bissey 2009-12-15 02:16:37 UTC
Created attachment 213058 [details]
ebuild proted to cmake-utils.eclass

I am attaching an "OverView" (and gl2ps) less version of the ebuild
I posted in the science overlay. It has also been cleaned a little bit 
around the edge.
The main advantage of this ebuild is it doesn't depend on anything 
unstable making it a good candidate for stabilization as well.
It also take care of bug #273117 .
Comment 8 Tomáš Chvátal (RETIRED) gentoo-dev 2009-12-15 08:45:14 UTC
Dont depend on cmake, its handled by eclass.

This is plain wrong:
dohtml "${D}/usr/bin/about.html" && rm -f "${D}/usr/bin/about.html" \
		|| die "Failed to move about.html into doc dir"

Also just place cmake-utils as last in inherit order and drop src_compile.

New syntax for cmakelists the current one will be deprecated:
mycmakeargs+=(
"argument"
"argument"
"argument"
)


Comment 9 François Bissey 2009-12-15 20:42:36 UTC
(In reply to comment #8)
> This is plain wrong:
> dohtml "${D}/usr/bin/about.html" && rm -f "${D}/usr/bin/about.html" \
>                 || die "Failed to move about.html into doc dir"
Fixing that will require patching cmake files somewhere, it is
generated and of course there is a rule to install it somewhere.
Or we could just remove it.
Comment 10 François Bissey 2009-12-15 20:44:13 UTC
Created attachment 213136 [details]
OK ported to the newest cmake-utils eclass and with an added patch.
Comment 11 François Bissey 2009-12-15 20:44:55 UTC
Created attachment 213137 [details, diff]
patch for detecting nvidia-cg-toolkit on Gentoo
Comment 12 François Bissey 2009-12-16 08:55:18 UTC
Created attachment 213161 [details]
fix the about.html thing patch for it following

OK it was easier to fix the about.html issue than I expected.
Comment 13 François Bissey 2009-12-16 08:56:06 UTC
Created attachment 213163 [details, diff]
patch to avoid installing about.hml in /usr/bin
Comment 14 Markus Dittrich (RETIRED) gentoo-dev 2009-12-17 23:20:14 UTC
Thanks, Francois.

I hope I can have a look at this over the holidays a
bit. Keep up the good work :)

cheers,
Markus
Comment 15 Tomáš Chvátal (RETIRED) gentoo-dev 2009-12-23 17:23:31 UTC
Ok guys, this is last direct cmake user in main tree, so chop chop :D
Comment 16 Markus Dittrich (RETIRED) gentoo-dev 2010-01-12 03:12:05 UTC
(In reply to comment #15)
> Ok guys, this is last direct cmake user in main tree, so chop chop :D
> 

I am embarassed :( Hopefully, I'll get this done this week.

Thanks for your patience.

cheers,
Markus 
Comment 17 François Bissey 2010-01-12 09:30:22 UTC
I haven't checked it yet but we probably can as well revbump to version
3.6.2, which came out last week, at the same time. 
The release notes mentioned a new plugin but I haven't seen a config
option for it. Other than that it is a maintenance release so no real changes.
Comment 18 Markus Dittrich (RETIRED) gentoo-dev 2010-01-16 20:52:28 UTC
I've just added a paraview-3.6.2 ebuild which has all of
these fixes. 

Thanks to everybody, but in particularly Francois for their great help.

Best,
Markus