Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 28700 - metacity: add option to set animation style
Summary: metacity: add option to set animation style
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Linux Gnome Desktop Team
Depends on:
Reported: 2003-09-14 06:55 UTC by Sebastian Dröge
Modified: 2004-07-11 13:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

the patch for 2.6.1 (metacity-anim.diff,7.09 KB, patch)
2003-09-14 06:55 UTC, Sebastian Dröge
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Dröge 2003-09-14 06:55:11 UTC
at there were some discussion
about adding an option to disable animations or set other animation styles in
metacity. the result was not to add such option but there was a working patch.
maybe we could add this patch to the metacity ebuild? it only adds a gconf key
and works
i'll attach a patch which applies cleanly to metacity 2.6.1


Reproducible: Always
Steps to Reproduce:
1.minimize a window in metacity
2.wondering about the ugly animation
3.searching an option to turn it off
Actual Results:  
no option found ;)

Expected Results:  
there shall be an option to setup the animation styles
Comment 1 Sebastian Dröge 2003-09-14 06:55:45 UTC
Created attachment 17697 [details, diff]
the patch for 2.6.1
Comment 2 foser (RETIRED) gentoo-dev 2003-09-21 11:39:00 UTC
the problem i have with adding options that are not going to be in mainstream is that we may not be able to maintain the patch in the future, resulting in regressions.

thoughts on this ?
Comment 3 Sebastian Dröge 2003-09-21 11:50:05 UTC
I think we'll can maintain the patch for longer time. The original patch was from october 2002, that's almost a year...

also most people won't notice it, when the patch isn't applied in future versions, because it's just one gconf key and no option with a GUI

i think we don't loose much if we add it's your decision. if it's only me who wants this I can apply it by hand in any future version ;)
Comment 4 Mystilleef 2003-10-02 10:51:10 UTC
Err...has the patch been applied? I'm using metacity-2.6.1 and I can't find
it via the gconf editor. Any help will be appreciated.
Comment 5 Mystilleef 2003-10-02 10:53:13 UTC
Okay, silly I just noticed the patch in the attachment. Could anyone direct
me on how to install the patch? I'm totally illiterate when it come to these
things. :-(
Comment 6 Yi Quang (RETIRED) gentoo-dev 2003-12-22 21:19:46 UTC
I think that the window animations in metacity is a major annoyance for a lot of people, and adding a minor patch like this will not cause too big problems in the future.  
Comment 7 Spider (RETIRED) gentoo-dev 2003-12-23 00:37:46 UTC
some input on this , not with regards to wether we'll take it or not, mind you.

a)  We must use a different namespace for the key. See gnome 2.x development requirement. (Avoid namespace collision and compability)

b)  does this still apply to CVS HEAD,  Care to check how much work it is to actually make it apply?  Yep, thats crucial so it actually will survive. 

Comment 8 Yi Quang (RETIRED) gentoo-dev 2003-12-23 16:30:35 UTC
I'm not sure if anyone actually read the thread.  Havoc seems to be against including it, seems almost like a personal issue to me.  And no, it is not fixed in CVS head.  I'm not sure what you mean by namespace, urls?
Comment 9 Spider (RETIRED) gentoo-dev 2003-12-23 17:23:28 UTC
its an anti-crack thing:

namespace is documented at afaik, its the question that a gconf key cannot change meaning, may not collide and so on, so if we add it we should add apps/metacity/gentoo_animationfeature   or something like that, so we don't collide in the future. (it has to be forwards compatible too)

and yes, I read the thread.

What I meant about apply to CVS HEAD, is that :  can you check that the patch even works against gnome 2.5 metacity, and that there isn't any collissions, and that you can keep maintaining it. (no, its not an issue for "later" but one for "now" as to add it at this point means we have to keep supporting it )
Comment 10 Spider (RETIRED) gentoo-dev 2004-07-11 13:48:58 UTC
No feedback for willing maintainers, closing