Hi, attached patch fixes a couple of dependency issues with wxGTK ebuild. Detailed description of changes: * removed dependency on media-libs/netpbm, media-libs/giflib and dev-libs/libunicode -- wxGTK does not use any of them * use global USE flags png,jpeg and tiff to optionally compile out support for libpng, libjpeg or libtiff * use --without-libFOO if the flag is not set instead of using --with-libFOO (which is configure's default and so is not needed at all) * moved all the dependencies from DEPEND to RDEPEND -- they are needed at runtime, not only for compilation (dependency on shared libs) * removed sys-devel/gettext from RDEPEND because wxGTK does not use GNU gettext (it contains its own implementation of .mo files loader) * commented out the check that does not allow gtk2 to be used together with odbc -- odbc works just fine with gtk2, it conflicts with unicode, which is not used anymore by the ebuild (I did not delete the checks completely, because they will have to be restored when Unicode build is restored) Reproducible: Always Steps to Reproduce:
Created attachment 17685 [details, diff] fixed ebuild patch
*** Bug 28682 has been marked as a duplicate of this bug. ***
*** Bug 28683 has been marked as a duplicate of this bug. ***
sorry this has taken so long. i've done some testing on disabling libtiff/jpeg/png support and unfortunately, it has some very bad consequences for wxPython if I disable any one of those. unless there is a solution to wxPython (which isn't very simple because in src/gtk/image.cpp, it assumes all the graphic format support all the way.) then I can't introduce those changes.
I don't particularly care about this part of the patch (although it would be nice to disable say TIFF support if I never use it -- I'll ask wxPython folks about it), it's the rest of the patch that is important. I'm attaching modified version of the patch that does not have jpeg,png and tiff USEs in it.
Created attachment 18626 [details, diff] revised patch that doesn't have jpeg,png,tiff dependencies configurable
Please, could you add configurabe unicode support as well? I really need it since I'm developing some stuff for the Windows boxes and I use unicode to get rid of the codepage problems. One little "unicode" USE flag can solve this (currently, it's disabled by defalut and I need to keep my own modified ebuild which sucks)... Thanks... Radek
I plan to do it (when I need it...) -- it will have to build Unicode version _in addition_ to ANSI one because too many wx applications would break with Unicode build...
Yeah! That would be even better. But I don't know what should "wx-config --libs" return then... :-(
...and I forgot to mention, for example btdownloadgui (the BitTorrent GUI) breaks _without_ unicode... :-)
Created attachment 18925 [details] wxGTK-2.4.1-r2.ebuild This is an ebuild that adds support for both unicode and debug. The unicode was disabled by default to keep some compatibility with other apps like xMule (maybe lMule) and like but since wxGTK is intended mostly for developers, they need to have a nice way to play with both unicode and debug stuff (at least, I need it desperately). Leaving it disabled (default) doesn't break anything so "normal" users won't even notice the difference. After accepting this, you can close bug 29042 (the request fo debug support)... Thanks... Radek
As discussed previously, this approach to Unicode support is not acceptable (that was my understating, please correct me if I am wrong) because it breaks other applications if Unicode is enabled (which may happen). The proposed solution (no patch yet) was to build Unicode version *in addition* to ANSI one -- i.e. to be able to have both ANSI version (for "legacy" apps) and Unicode one (e.g. for wxPython or poedit packages).
You are absolutely correct but this was intended to be a step-ahead towards the developers. Normal user (the one who wants non-unicode dependant stuff) should never get into situation when unicode (and debug) is enabled automatically for him, so technically, it makes no difference. The advantage is that the developer can use the -->USE="unicode debug" emerge wxGTK<-- formula to easily get what he needs (considering he doesn't need the non-unicode dependant apps, which is quite common anyway)... Of course the multiple-libs approach is the best but nobody seems to have enough time to create such an ebuild so I've tried to help a bit (at least to myself)... :-( Radek
i've just committed wxGTK-2.4.2 which is currently masked for some stablity testing. i've incorporated the following changes: 1. added the tiff/jpeg/png deps. i couldn't find the any netpbm dependencies nor could i find libunicode being used anywhere. wxGTK has it's own wchar_t support. 2. i've added the debug and unicode useflags. the reason i put the unicode useflag in is because it will be disabled by default. we are a distro that is supposed to be friendly to developers, so i think there is enough justification to let the users decide if they want unicode support or not. 3. i've cleaned up the ebuild quite a bit and made odbc properly be blocked on unicode. i still need to test whether it can work with unicode or not though. the new wxGTK-2.4.2 ebuild is in package.mask right now because i need some time for testing and feedback. can you please give it a try and let me know if you find any problems? thanks
> 3. i've cleaned up the ebuild quite a bit and made odbc properly be blocked > on unicode. i still need to test whether it can work with unicode or not > though. It can't, our ODBC code in wxWindows is not Unicode friendly yet (it does not compile if wxUSE_UNICODE=1). > 2. i've added the debug and unicode useflags. the reason i put the unicode > useflag in is because it will be disabled by default. I'm happy with it this way, because I have no intention of using the broken wx apps and wxPython ebuild will be easy to modify to support this. Sorry for my previous comment, it was based on what I thought was official position to exactly this Unicode handling proposal: From liquid@gentoo.org: > > Also, it's pity that Unicode is disabled even when gtk2 is in USE. I > > understand the reasoning perfectly, of course, but it would be nice > > to have Unicode build wxPython (which is compatible with non-Unicode > > It is a pity. Because I've always wanted Unicode support on wxGTK, > except that it breaks many of the wxGTK apps that aren't written with > unicode in mind. One of the examples would be xmule which seems to be > the most popular wxGTK apps in portage. I know that vlc and poedit have > both got wchar support figured out. But because of regresison, we can't > break those few apps that don't cater for unicode.
thanks for the confirmation about odbc and unicode. i could remember where the reference was that said they were incompatible. and yes, you are right about what i said previously about unicode. although after some considerations, i'd rather make it tweakable by those who know what they are doing. for most gentoo users, they will probably never enable unicode on wxGTK until we make it default because the unicode flag is a local useflag. local useflags are disabled by default. thank you for sticking up for my (previous) views :)
wxGTK-2.4.2 and wxPython-2.4.2.4 is now in ~x86.
