Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 286632 - x11-libs/xosd-2.2.14-r1 installs broken xosd-config
Summary: x11-libs/xosd-2.2.14-r1 installs broken xosd-config
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Alex Alexander (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-27 09:17 UTC by Andrew Savchenko
Modified: 2013-02-02 04:03 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
disable dups removal (xosd-2.2.14-no-reordering.patch,380 bytes, patch)
2009-09-27 09:50 UTC, Andrew Savchenko
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Savchenko gentoo-dev 2009-09-27 09:17:13 UTC
Hello,

xosd installs its own xosd-config script, but this script fails to handle gcc options containing space like "--param l1-cache-size=32":

$ grep ^af_cflags /usr/bin/xosd-config
af_cflags="-march=core2 -m32 --param l1-cache-line-size=64 --param l1-cache-size=32 --param l2-cache-size=512 -O2 -funswitch-loops -fpredictive-commoning -fgcse-after-reload -fomit-frame-pointer -mfpmath=sse -pipe  -Wall"

$ xosd-config --cflags
-march=core2 -m32 --param l1-cache-line-size=64 l1-cache-size=32 l2-cache-size=512 -O2 -funswitch-loops -fpredictive-commoning -fgcse-after-reload -fomit-frame-pointer -mfpmath=sse -pipe -Wall -I/usr/include

This happens because duplicated options are blindly removed. Instead either --param and its argument should not be touched or it should be treated as a single argument or unification should be dropped at all.
Comment 1 Andrew Savchenko gentoo-dev 2009-09-27 09:50:54 UTC
Created attachment 205361 [details, diff]
disable dups removal

This patch disables reordering and duplicate removing for non-libs arguments, thus --param and alike gcc options may be used safe now.
Comment 2 Alex Alexander (RETIRED) gentoo-dev 2013-02-02 04:03:17 UTC
patch applied in xosd-2.2.14-r2

thanks :)