# Copyright 1999-2004 Gentoo Foundation should be updated to # Copyright 1999-2009 Gentoo Foundation if the file was edited in 2009 Reproducible: Always Steps to Reproduce: 1. emerge x11-apps/xinit 2. etc-update 3. observe the header in the new /etc/init.d/xdm Actual Results: Header reads:- #!/sbin/runscript # Copyright 1999-2004 Gentoo Foundation # Distributed under the terms of the GNU General Public License, v2 # $Header: /var/cvsroot/gentoo-x86/x11-apps/xinit/files/xdm.initd-3,v 1.2 2009/09/15 00:27:45 williamh Exp Expected Results: #!/sbin/runscript # Copyright 1999-2009 Gentoo Foundation # Distributed under the terms of the GNU General Public License, v2 # $Header: /var/cvsroot/gentoo-x86/x11-apps/xinit/files/xdm.initd-3,v 1.2 2009/09/15 00:27:45 williamh Exp This is an example of a whole class of bug and not specific to this package. QA commit tools should check and possibly correct this class of bug.
Added trustees@g.o to CC: as we are interested in this sort of thing
Lets give this to portage, not sure who should do that, or if its even a good idea
doesn't repoman already do this? or maybe it only does it for ebuilds?
(In reply to comment #3) > doesn't repoman already do this? or maybe it only does it for ebuilds? repoman doesn't, but I think echangelog does. repoman has the "ebuild.badheader" check which complains if the mtime of the ebuild is newer than the year in the header.
Ok, so echangelog needs to look further for updating files.
(In reply to comment #5) > Ok, so echangelog needs to look further for updating files. > Hrm...well, echangelog is just for the changelog. I don't think echangelog should touch something else than changelog.
<hat type="trustee"> echangelog already updates ebuilds and the changelog. Please see about updating stuff in files/ where it can be done safely (eg not to patches or binaries), as we do need to keep the copyrights updated when other changes are made. </hat>
Trustees input stands already here per prior meeting. Just need echangelog changed as noted in comment #7. CC us again if you need us.
(In reply to comment #7) > <hat type="trustee"> > echangelog already updates ebuilds and the changelog. > Please see about updating stuff in files/ where it can be done safely (eg not > to patches or binaries), as we do need to keep the copyrights updated when > other changes are made. > </hat> > This should be fixed in gentoolkit-dev-9999 and gentoolkit-dev > 0.2.6.14. Please test it and let me know if it works properly or not.
This has been fixed in gentoolkit-dev-0.2.7.
