Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 284951 - dev-util/lafilefixer should support removal of libraries (for x11-libs/libxcb removal of libxcb-xlib)
Summary: dev-util/lafilefixer should support removal of libraries (for x11-libs/libxcb...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
: 342995 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-09-14 15:40 UTC by SpanKY
Modified: 2013-07-12 00:15 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SpanKY gentoo-dev 2009-09-14 15:40:25 UTC
we already have dev-util/lafilefixer.  we dont need yet another .la fixer with its own set of bugs and fixes.
Comment 1 SpanKY gentoo-dev 2009-09-14 15:42:14 UTC
same probably goes for broken dependency scanner (i.e. revdep-rebuild)
Comment 2 Rémi Cardona (RETIRED) gentoo-dev 2009-09-14 15:48:31 UTC
lafilefixer doesn't fix what we want fixed. lafilefixer can't handle the libxcb upgrade.

As for revdep-rebuild, I don't see what's wrong with it. Hopefully, if portage 2.2 ever gets released, then we won't have to suggest using revdep.

Thanks
Comment 3 SpanKY gentoo-dev 2009-09-14 16:03:04 UTC
then file a bug to get it fixed.  we dont need to go copying and pasting similar logic everywhere.  that is simply broken software development.
Comment 4 Rémi Cardona (RETIRED) gentoo-dev 2009-09-14 16:21:39 UTC
It's just a wrapper script for a simple sed. That's _it_. It looks fancy but it isn't. It only does _one_ thing, the rest is just cruft. I could have just told users to run the sed line. We made a script out of it to make it more user friendly and to avoid copy-paste errors.

But if you insist, let's see what Peter thinks.

Thanks
Comment 5 Peter Alfredsen (RETIRED) gentoo-dev 2009-09-14 17:04:54 UTC
(In reply to comment #4)

> But if you insist, let's see what Peter thinks.

I think lafilefixer would not have been any good for the libxcb upgrade. As it currently stands, lafilefixer is just a fancy way of getting .la files to reference by -L$libdir -l$library. It could remove libraries with a slight bit of patching, and that's on the list of things to do eventually, but that will probably involve reading the dependencies of the .so and regenerating the dependency_libs. But for the s:\b/usr/lib[^/]+/libcxb-xlib.la(\b):\1:' that is needed here, that would probably be overkill. Especially when the easiest way to get rid of the .la problem is to just remove the darned things. Lafilefixer allows you to do that without any unnecessary breakage resulting and it does it quite well.
Comment 6 SpanKY gentoo-dev 2009-09-14 21:13:21 UTC
of course ive read the code.  i wouldnt have filed a bug otherwise.

libxcb's fixer is removing references to a library that no longer exists.  lafilefixer should support that use case and then libxcb can run that instead.  if it doesnt yet, then once support is added we can fix libxcb.

while this use case doesnt come up too often, it has happened before so we might as well do it right once instead of recreating the wheel over and over.
Comment 7 Gilles Dartiguelongue (RETIRED) gentoo-dev 2011-04-19 19:30:01 UTC
*** Bug 342995 has been marked as a duplicate of this bug. ***
Comment 8 Sergey Popov gentoo-dev 2013-07-12 00:15:52 UTC
lafilefixer was dropped from tree(see bug #289899), closing as WONTFIX