Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 284609 - dev-db/phpmyadmin-3.2.0.1.ebuild should not depend on mysql
Summary: dev-db/phpmyadmin-3.2.0.1.ebuild should not depend on mysql
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: High normal with 1 vote (vote)
Assignee: Gentoo Web Application Packages Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-11 14:39 UTC by Fabiano Francesconi
Modified: 2010-08-21 09:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
phpmyadmin_patch.ebuild (phpmyadmin.patch,1.64 KB, text/plain)
2009-09-14 14:33 UTC, rex
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fabiano Francesconi 2009-09-11 14:39:26 UTC
I think phpmyadmin should not depend on virtual/mysql since it could be utilised to administer remotely a MySQL DB Server (then no need to install it locally).
Comment 1 Benedikt Böhm (RETIRED) gentoo-dev 2009-09-11 16:20:01 UTC
you need mysql for the client library
Comment 2 rex 2009-09-11 18:28:31 UTC
(In reply to comment #1)
> you need mysql for the client library
> 

Correct but you don't need it to run phpmyadmin so I think that the ebuild should use

RDEPEND="dev-lang/php[mysql,mysqli]"

instead of

RDEPEND=">=virtual/mysql"

Because if you have php without the mysql use flag you can't run phpmyadmin even if you have mysql installed on your system.
Comment 3 Fabiano Francesconi 2009-09-11 18:38:21 UTC
I'll reopen this, then.
Comment 4 MT 2009-09-12 09:46:52 UTC
(In reply to comment #2)
> RDEPEND="dev-lang/php[mysql,mysqli]"
> Because if you have php without the mysql use flag you can't run phpmyadmin
> even if you have mysql installed on your system.

I agree, indeed the dependency on the MySQL's virtual is redundant as the function pkg_setup() just check for the right PHP's USE: mysql, mysqli, injecting all the required MySQL's virtuals. IMHO there is not need to declare RDEPEND="dev-lang/php[mysql,mysqli] unless we get rid of all the calls to require_php_with_* functions and we convert the ebuild to EAPI2.
Comment 5 rex 2009-09-14 14:33:44 UTC
Created attachment 204060 [details]
phpmyadmin_patch.ebuild
Comment 6 rex 2009-09-14 14:37:00 UTC
I've create an ebuild patch for the phpmyadmin-3.2.0.1 which fix the virtual/mysql dependency.

As I wrote before the new ebuild use the EAPI="2" with RDEPEND on dev-lang/php. With this version we don't need the pkg_setup() function because the USE flags for php are listed on the RDEPEND section.

The main problem in that if a user change delete the mysqli use flags phpmyadmin doesn't work anymore.
Comment 7 rex 2009-09-14 14:56:41 UTC
I'm sorry for the double post but I realize that I could be more strict in describe why and how I changed the original ebuild.

In the previous version with RDEPEND="virtual/mysql" a if a user change the php use flags with -mysql the phpmyadmin package doesn't work anymore. With the EAPI="2" version of the ebuild all these things are handle by portage.
Comment 8 Alex Legler (RETIRED) archtester gentoo-dev Security 2010-08-21 09:43:01 UTC
The dependency is gone in the new ebuild. (3.3.5.1)