Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 282426 - net-p2p/dclib: breaks with forced --as-needed
Summary: net-p2p/dclib: breaks with forced --as-needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Gentoo net-p2p team
URL: http://www.gentoo.org/proj/en/qa/asne...
Whiteboard:
Keywords:
Depends on:
Blocks: as-needed
  Show dependency tree
 
Reported: 2009-08-23 12:27 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2010-03-23 10:38 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (dclib-0.3.23:20090823-122112.log,86.18 KB, text/plain)
2009-08-23 12:28 UTC, Diego Elio Pettenò (RETIRED)
Details
adding epatch and autotools + update (dclib-0.3.23.diff,878 bytes, patch)
2010-03-21 14:32 UTC, Kacper Kowalik (Xarthisius) (RETIRED)
Details | Diff
fixing as-needed issues (dclib-0.3.23-as-needed.patch,728 bytes, patch)
2010-03-21 14:33 UTC, Kacper Kowalik (Xarthisius) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2009-08-23 12:27:13 UTC
I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Please note that this bug _might_ apply to -Wl,--as-needed in LDFLAGS as well; in both cases it should be fixed. Also, if this is due to the package in question not respecting user-defined LDFLAGS, you should get to fix that too.

Check the attached build log.

Thanks,
Diego

P.S.: the tests fail because the library has undefined references, software using dclib would also fail.
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-08-23 12:28:23 UTC
Created attachment 202020 [details]
Build log
Comment 2 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2009-10-31 14:36:46 UTC
Failed to reproduce that. Could it be that something linked to dclib/.libs/libdc.so is missing pthreads instead??
Comment 3 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2010-03-21 14:32:50 UTC
Created attachment 224517 [details, diff]
adding epatch and autotools + update

Summary of changes:
 * added base.eclass to skip src_install
 * bumped to EAPI=2 to get src_prepare
 * added missing RDEP="$DDEP"
 * added epatch and autoreconf, since I'm meddling with m4 macro
Comment 4 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2010-03-21 14:33:22 UTC
Created attachment 224519 [details, diff]
fixing as-needed issues
Comment 5 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2010-03-21 14:35:18 UTC
(In reply to comment #2)
> Failed to reproduce that. Could it be that something linked to
> dclib/.libs/libdc.so is missing pthreads instead??
It was failing in test phase, I don't even remember why I couldn't reproduce it back then. 

Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2010-03-23 10:38:14 UTC
+  23 Mar 2010; Samuli Suominen <ssuominen@gentoo.org> dclib-0.3.23.ebuild,
+  +files/dclib-0.3.23-asneeded.patch:
+  Fix building with -Wl,--as-needed wrt #282426 by Kacper Kowalik. Fix
+  missing USE="socks5" and USE="ssl" wrt #285661 by Andreis Vinogradovs.