Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 279335 - [patch] dev-tcltk/expect-5.43.0: expect-5.43.0-missing-includes.patch is not enough
Summary: [patch] dev-tcltk/expect-5.43.0: expect-5.43.0-missing-includes.patch is not ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: TCL/TK Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-27 15:36 UTC by OKUMURA N. Shin-ya
Modified: 2010-12-17 22:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
more missing-include patch (expect-5.43.0-missing-includes-tk.patch,303 bytes, patch)
2009-07-27 15:37 UTC, OKUMURA N. Shin-ya
Details | Diff
My emerge --info (emerge-info.txt,4.83 KB, text/plain)
2009-08-02 14:56 UTC, OKUMURA N. Shin-ya
Details
build.log (build.log,47.66 KB, text/plain)
2009-08-02 15:02 UTC, OKUMURA N. Shin-ya
Details

Note You need to log in before you can comment on or make changes to this bug.
Description OKUMURA N. Shin-ya 2009-07-27 15:36:50 UTC
expect-5.43.0-missing-includes.patch is not enough, when with USE=tk.

Reproducible: Always

Steps to Reproduce:
1. USE=tk emerge =dev-tcltk/expect-5.43.0
2.
3.

Actual Results:  
Implicit declaration of function: strchr (and so on)

Expected Results:  
It would emerge successfully.

The similar fix is included in expect-5.43.0-missing-includes.patch but it is not enough.
Comment 1 OKUMURA N. Shin-ya 2009-07-27 15:37:47 UTC
Created attachment 199351 [details, diff]
more missing-include patch
Comment 2 James Earl Spahlinger 2009-07-29 04:21:32 UTC
I attempted to reproduce on amd64 stage3 chroot with no luck in getting the issue.

Could you show us your emerge --sync and the error from the compile?
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-08-02 11:58:17 UTC
I think James confused "emerge --sync" with "emerge --info"  ;)

Please post your "emerge --info" and attach the build.log file of the failed emerge to this bug.
Comment 4 OKUMURA N. Shin-ya 2009-08-02 14:56:09 UTC
Created attachment 199933 [details]
My emerge --info

emerge --info says as the attachment.
Comment 5 OKUMURA N. Shin-ya 2009-08-02 15:02:12 UTC
Created attachment 199934 [details]
build.log

The build.log says, 'Please do not file a Gentoo bug', but I guess it is merely a short of expect-5.43.0-missing-includes.patch.
Comment 6 Wormo (RETIRED) gentoo-dev 2009-08-08 06:25:35 UTC
Ah ha, you have FEATURES=stricter set. The effect of that feature is to turn QA warnings into errors, similar to how some compilers have flags that turn warning messages into errors. This is only supposed to be used by developers who are in the mode of trying to fix every last warning, because when warnings cause a build to fail they will never be overlooked.

Since you were surprised by this build failure, obviously this is not your intention and you should turn off this feature.

Go ahead and try again without "stricter", and hopefully you can report back that it works :)
Comment 7 OKUMURA N. Shin-ya 2009-08-09 10:19:33 UTC
O.K, it works with FEATURES=-stricter.

Thanks for your information.
Should I turn it to 'invalid', and so on?
Comment 8 SpanKY gentoo-dev 2010-12-17 22:56:32 UTC
thanks ... ive added your include changes to 5.44.1.15