Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 279268 - sci-geosciences/gmt-4.5.0-r1: broken CFLAGS
Summary: sci-geosciences/gmt-4.5.0-r1: broken CFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Sci-geo Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-27 07:15 UTC by Martin von Gagern
Modified: 2018-11-03 23:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Drop manipulation of several flags (gmt-4.5.0-no-strip.patch,1.91 KB, patch)
2009-07-27 07:23 UTC, Martin von Gagern
Details | Diff
Drop manipulation of several flags (gmt-4.5.0-no-strip.patch,1.92 KB, patch)
2009-07-27 07:42 UTC, Martin von Gagern
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin von Gagern 2009-07-27 07:15:43 UTC
I fear my patch from bug 145277 comment 12 isn't enough.

i686-pc-linux-gnu-gcc -march=prescott -O2 gdb -O2 -pedantic -Wall -fPIC -fno-strict-aliasing -I/usr/include -DGMT_SHARE_PATH=\"/usr/share/gmt-4.5.0\" -DTRIANGLE_D   -c -o pslib.o pslib.c
i686-pc-linux-gnu-gcc: gdb: No such file or directory
make[1]: *** [pslib.o] Error 1
make[1]: Leaving directory `/var/tmp/portage/sci-geosciences/gmt-4.5.0-r1/work/GMT4.5.0/src'
make: *** [suppl] Error 2
make: *** Waiting for unfinished jobs....
make[1]: *** [pslib.o] Error 1
make[1]: Leaving directory `/var/tmp/portage/sci-geosciences/gmt-4.5.0-r1/work/GMT4.5.0/src'
make: *** [gmt] Error 2
 * 
 * ERROR: sci-geosciences/gmt-4.5.0-r1 failed.
 * Call stack:
 *               ebuild.sh, line   49:  Called src_compile
 *             environment, line 2701:  Called die
 * The specific snippet of code:
 *       emake gmt ${mymake} || die "Make ${mymake} failed."
 *  The die message:
 *   Make  suppl failed.

The reason is that configure does CFLAGS=`echo $CFLAGS | sed 's/-g//'` but I have CFLAGS="-march=prescott -O2 -ggdb". There seems to be an awful lot of flags hackery in that configure script.

Makes me think of bug #257489 where similar hacks were used upstream, and dropped at the distro level.

I'll attach a more rigorous patch weeding more of these hacks.
Comment 1 Martin von Gagern 2009-07-27 07:23:16 UTC
Created attachment 199284 [details, diff]
Drop manipulation of several flags

This patch is a replacement for the current no-strip patch.
It now also contains a verbose header for later reference.
Maybe I'll even try to get upstream interested in this thing.
Comment 2 Martin von Gagern 2009-07-27 07:42:34 UTC
Created attachment 199288 [details, diff]
Drop manipulation of several flags

I had created that previous version against the configure script created by the autoreconf called by the ebuild. It failed to apply against the configure script shipped with the sources. This one here works for me. I know I probably should be testing my patches more thoroughly before submitting them here...
Comment 3 Martin von Gagern 2009-07-27 08:41:46 UTC
(In reply to comment #1)
> Maybe I'll even try to get upstream interested in this thing.

Upstream discussion: http://thread.gmane.org/gmane.comp.gis.gmt.user/11760
Comment 4 Martin von Gagern 2009-12-07 21:03:46 UTC
Patch available for well over four months now. Any reason to not include it in portage?
Comment 5 Justin Lecher (RETIRED) gentoo-dev 2010-06-24 19:45:41 UTC
+*gmt-4.5.0-r2 (24 Jun 2010)
+
+  24 Jun 2010; Justin Lecher <jlec@gentoo.org> gmt-4.0.ebuild,
+  gmt-4.1.1.ebuild, -gmt-4.5.0-r1.ebuild, +gmt-4.5.0-r2.ebuild,
+  files/gmt-4.5.0-no-strip.patch:
+  Correct handling of *FLAGS, thanks Martin von Gagern for providing the
+  patch
+
Comment 6 Martin von Gagern 2018-11-03 23:00:00 UTC
Just filed bug 670226 reporting a regression on this for gmt-4.5.18.