Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 279198 - app-emulation/virtualbox-bin-* has no `check_license` and has RESTRICT="strip"
Summary: app-emulation/virtualbox-bin-* has no `check_license` and has RESTRICT="strip"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Patrick Lauer
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-26 17:46 UTC by Leonid Evdokimov
Modified: 2010-05-19 16:51 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Leonid Evdokimov 2009-07-26 17:46:07 UTC
Summary from IRC #gentoo-sunrise:

<darkk^> ssuominen, one more question on EULA. I looked at virtualbox-bin, it does not call `check_license`, though PUEL says «If you do not agree to all conditions set forth by this license, you may not use the product...»
<ssuominen> It's a bug.
...
<darkk^> hmm, `check_license` was removed from virtualbox-bin once, it was there on 03 Sep 2008 (see ChangeLog)
<ssuominen> it's fetch restricted right?
<ssuominen> maybe the page you have to download it from already makes you accept the license?
<ssuominen> that's the only reasoning i can figure
<ssuominen> or explicit upstream permission which isn't clear here if not mentioned in the changelog
...
<darkk^> virtualbox-bin has only RESTRICT="strip" and the installers are at gentoo mirrors, so I conclude that it's not fetch restricted too.
<ssuominen> that's also wrong
<ssuominen> it shouldn't have RESTRICT="strip"
<ssuominen> it should have QA_PRESTRIPPED
Comment 1 Wormo (RETIRED) gentoo-dev 2009-07-27 00:24:46 UTC
Thanks for reporting these QA issues -- assigning to maintainers.
Comment 2 Alessio Cassibba (X-Drum) 2009-07-27 23:16:37 UTC
(In reply to comment #0)
[..]
> <darkk^> hmm, `check_license` was removed from virtualbox-bin once, it was
> there on 03 Sep 2008 (see ChangeLog)
[..]

Not sure how it happened and why but yes restrictions on ebuilds somehow vanished.

The license is clear on this, so i added back "check_license" to all the affected ebuilds, on virtualbox-bin ebuilds RESTRICT="strip"
was dropped and replaced by QA_PRESTRIPPED.

Updated ebuilds are on jokey's overlay: 
http://overlays.gentoo.org/dev/jokey