Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 278641 - dev-util/quilt-0.48: bash completion of patch names fails
Summary: dev-util/quilt-0.48: bash completion of patch names fails
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Development Tools Team
URL: https://savannah.nongnu.org/bugs/inde...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-22 08:06 UTC by Martin von Gagern
Modified: 2012-03-18 19:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin von Gagern 2009-07-22 08:06:38 UTC
The bash completion from dev-util/quilt-0.48 fails to complete patch names with app-shells/bash-4.0_p24. This is due to the fact that the completion function uses "quilt series", "quilt applied" and similar internally, which in turn output the paths of the patch files relative to the current working directory, instead of simply the file names as are usually used.

So the possible completions start with "patch/", "../../patch/" or something similar, depending on how deep in the tree you currently are. If you changed $QUILT_PATCHES, that directory will of course change as well. Completion using these full paths will work, but isn't what users would expect. It also isn't what the list of possible completions prints; it seems that this list does strip directory names from its output. So a listed completion doesn't work when typed, which is very irritating.

Steps to reproduce:
1. mkdir foo
2. unset QUILT_PATCHES
3. cd foo
4. mkdir patches
5. quilt new foo.patch
6. quilt new bar.diff
7. quilt header <press tab twice here>
   -a         -h          -r
   --backup   bar.diff    --strip-diffstat
   -e         foo.patch   --strip-trailing-whitespace
8. quilt header f<press tab here>
   <no completion at all!!!>
9. quilt series
   patches/foo.patch
   patches/bar.diff

I guess the solution would be to pipe the output of all those internall quilt patch listing commands through something that strips directory names, like
  sed -e 's:.*/::'

If you believe this should be addressed in an upstream bug report, let me know.
Comment 1 Mike Pagano gentoo-dev 2009-07-25 17:42:32 UTC
I believe this should go upstream.  
http://savannah.nongnu.org/bugs/?group=quilt

If you do open a bug with them, please post the url of the bug here. 

Comment 2 Martin von Gagern 2009-07-26 08:57:41 UTC
Reported upstream as https://savannah.nongnu.org/bugs/index.php?27111 .
Also attached patches to upstream bug.
Comment 3 Martin von Gagern 2011-11-23 10:25:46 UTC
Still no reaction upstream. Do you want to RESOLVE this UPSTREAM, or do you want to fix this at the distro level even if upstream remains unresponsive?