Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 278326 - [New ebuild] games-rpg/penumbra-collection-1.1
Summary: [New ebuild] games-rpg/penumbra-collection-1.1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Julian Ospald
URL: http://www.penumbragame.com
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2009-07-19 13:56 UTC by Róbert Čerňanský
Modified: 2012-12-18 19:03 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild for Penumbra Collection 1.0 (penumbra-collection-1.0.ebuild,4.91 KB, text/plain)
2009-07-19 13:57 UTC, Róbert Čerňanský
Details
License file. (PENUMBRA-COLLECTION,5.68 KB, text/plain)
2009-07-19 13:57 UTC, Róbert Čerňanský
Details
games-rpg/penumbra-overture-1.1.ebuild (penumbra-overture-1.1.ebuild,1.94 KB, text/plain)
2011-10-29 19:01 UTC, Jared B.
Details
games-rpg/penumbra-overture-1.1.ebuild (penumbra-overture-1.1.ebuild,2.00 KB, text/plain)
2011-10-29 19:05 UTC, Jared B.
Details
games-rpg/penumbra-collection-1.1.ebuild (penumbra-collection-1.1.ebuild,5.30 KB, text/plain)
2012-09-15 02:54 UTC, Jared B.
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Róbert Čerňanský 2009-07-19 13:56:13 UTC
Ebuild for Penumbra Collection released by Frictional Games. Penumbra Collection release contains all three Penumbra games - Overture, Black Plague and Requiem.
Comment 1 Róbert Čerňanský 2009-07-19 13:57:14 UTC
Created attachment 198472 [details]
Ebuild for Penumbra Collection 1.0
Comment 2 Róbert Čerňanský 2009-07-19 13:57:47 UTC
Created attachment 198474 [details]
License file.
Comment 3 Piotr Szymaniak 2009-07-21 20:50:56 UTC
I have a problem with the license when GAMES_CHECK_LICENSE=yes. Talked about this issue with Robert (bug reporter) and idl0r on #gentoo-sunrise. Looks like some error with eutils.eclass. Robert mentioned that it should work when the license file is in portage (licenses), but that's a poor fix as it will be removed with the next sync.


~ # emerge penumbra-collection -va

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild IN f  ] games-rpg/penumbra-collection-1.0  0 kB [1]

Total: 1 package (1 new, 1 interactive), Size of downloads: 0 kB
Fetch Restriction: 1 package
Portage tree and overlays:
 [0] /usr/portage
 [1] /home/lazy_bum/svn/roslin

Would you like to merge these packages? [Yes/No] y

>>> Verifying ebuild manifests

>>> Emerging (1 of 1) games-rpg/penumbra-collection-1.0 from roslin
 * PenumbraCollection-1.0.sh RMD160 SHA1 SHA256 size ;-) ...             [ ok ]
 * checking ebuild checksums ;-) ...                                     [ ok ]
 * checking auxfile checksums ;-) ...                                    [ ok ]
 * checking miscfile checksums ;-) ...                                   [ ok ]
 * 
 * ERROR: games-rpg/penumbra-collection-1.0 failed.
 * Call stack:
 *                        ebuild.sh, line   49:  Called pkg_setup
 *   penumbra-collection-1.0.ebuild, line   45:  Called games_pkg_setup
 *                     games.eclass, line  128:  Called check_license 'PENUMBRA-COLLECTION'
 *                    eutils.eclass, line 1321:  Called die
 * The specific snippet of code:
 *      [ ! -f "${lic}" ] && die "Could not find requested license ${lic}"
 *  The die message:
 *   Could not find requested license PENUMBRA-COLLECTION
 * 
 * If you need support, post the topmost build error, and the call stack if relevant.
 * A complete build log is located at '/var/log/portage/games-rpg:penumbra-collection-1.0:20090721-204114.log'.
 * The ebuild environment file is located at '/home/porttmp/portage/games-rpg/penumbra-collection-1.0/temp/die.env'.
 * This ebuild is from an overlay named 'roslin': '/home/lazy_bum/svn/roslin/'
 * 


(: pwd
/home/lazy_bum/svn/roslin/games-rpg/penumbra-collection
(: ll /home/lazy_bum/svn/roslin/licenses/
*snip*
-rw-r--r-- 1 lazy_bum lazy_bum 5820 07-19 18:58 PENUMBRA-COLLECTION
(: ll
razem 16
-rw-r--r-- 1 lazy_bum lazy_bum  278 07-21 22:23 ChangeLog
-rw-r--r-- 1 lazy_bum lazy_bum  601 07-21 22:38 Manifest
-rw-r--r-- 1 lazy_bum lazy_bum 4989 07-21 22:38 penumbra-collection-1.0.ebuild
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-07-22 18:15:03 UTC
Games are nothing base-system herd should be bothered with. Please don't CC maintainers/herds yourself. Leave that to the bug-wranglers.
Comment 5 Róbert Čerňanský 2009-07-25 10:51:21 UTC
Ebuild is now in the sunrise overlay:

http://overlays.gentoo.org/proj/sunrise/browser/reviewed/games-rpg/penumbra-collection
Comment 6 Tristan Heaven (RETIRED) gentoo-dev 2009-08-03 17:43:45 UTC
Your ebuild looks good but in my "testing" I found that the first game consistently segfaults near the end.
Comment 7 Róbert Čerňanský 2009-08-04 18:28:56 UTC
Hmm, I didn't get that far yet...

Do you have x86 or amd64 architecture? Would it be possible for you to install the game using directly the installer (as some test user, no need to install it as root) and test if it crashes too? The difference is that such installation will use bundled libraries instead of system ones.
Comment 8 Arun Raghavan (RETIRED) gentoo-dev 2010-05-05 10:55:30 UTC
Looks like the DEPEND needs to change to:

DEPEND="|| ( app-arch/xz-utils app-arch/lzma-utils )"

So as to not cause blockers.
Comment 9 Róbert Čerňanský 2010-05-05 20:05:29 UTC
Change committed to sunrise (http://overlays.gentoo.org/proj/sunrise/browser/sunrise/games-rpg/penumbra-collection). Thanks for the report.
Comment 10 Mike Nerone 2010-05-16 07:23:09 UTC
Version bump to 1.1 (it's at least included as part of the Humble Indie Bundle). ebuild-rename does not work, but I haven't had a chance to look at it. Just wanted to note it here.
Comment 11 Mike Nerone 2010-05-16 07:26:56 UTC
Sorry, I misspoke: it's not included with the Humble Indie Bundle (http://www.wolfire.com/humble), only Overture is. But when you install Penumbra Overture, you are offered a code to buy Penumbra Collection for $5, which I exercised, and what I was offered for download was PenumbraCollection-1.1.sh. That was straight from Frictional Games, so it's not really related to the Bundle thing. Sorry for my moment of confusion.

Fact remains: current version is 1.1.
Comment 12 Róbert Čerňanský 2010-05-16 19:25:23 UTC
Bumped to version 1.1. The ebuild was also fixed to avoid crashes like reported in the note #6.

New ebuild is currently available in the unreviewed sunrise overlay: http://overlays.gentoo.org/proj/sunrise/browser/sunrise/games-rpg/penumbra-collection?rev=10568.

Btw, on Friday Penumbra was released under GPL, yea!
Comment 13 Mike Nerone 2010-05-16 21:08:55 UTC
If I'm not mistaken, only Penumbra: Overture (the first in the series) was open-sources. Still, it's great news, and I commend Frictional!

BTW, perhaps an update to the bug subject is in order?
Comment 14 Jared B. 2011-10-29 19:00:03 UTC
I just purchased this from the Frictional Games store (they're currently running a Halloween sale - this + Amnesia for only $8), and the file I downloaded was named differently than what you have in the ebuild.  Instead of PenumbraOverture_1.1.sh, I received penumbra-overture-1.1.sh.  Renaming the file to what's in the ebuild made it install fine, but it'd be nice if you could modify the ebuild to support both by default to make it easier for users.  I took a crack at doing that myself, but didn't have much luck with setting multiple SRC_URIs but requiring only one.  I'd imagine there has to be some way to do this, though.

Aside from that (and partially as a workaround), I made a few other tweaks to the ebuild:

* Changed pkg_nofetch to be more explicit about the filename it expects
* Added a dependency to prevent collision with Penumbra: Overture (which has it's own separate ebuild in bugzilla)
* Deleted lzma tarballs after they were extracted to save a couple GB of PORTAGE_TMPDIR usage (helpful for RAM disk users)

The ebuild for the most part worked great, though, so thanks to everyone that contributed.  Looking forward to seeing this in portage at some point, and if anyone feels like taking the time, I still think it'd be nice for the ebuild to directly support the name of the file people buying it today will receive.
Comment 15 Jared B. 2011-10-29 19:01:28 UTC
Created attachment 291155 [details]
games-rpg/penumbra-overture-1.1.ebuild

Update containing aforementioned changes.  I should also mention that I pulled this from the sunrise overlay, so it has a lot more differences from the previous ebuild included in this bug report.
Comment 16 Jared B. 2011-10-29 19:05:18 UTC
Created attachment 291157 [details]
games-rpg/penumbra-overture-1.1.ebuild

fixed typo
Comment 17 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-10-29 19:15:38 UTC
(In reply to comment #14)
> I just purchased this from the Frictional Games store (they're currently
> running a Halloween sale - this + Amnesia for only $8), and the file I
> downloaded was named differently than what you have in the ebuild.  Instead of
> PenumbraOverture_1.1.sh, I received penumbra-overture-1.1.sh.  Renaming the
> file to what's in the ebuild made it install fine, but it'd be nice if you
> could modify the ebuild to support both by default to make it easier for users.

Do the checksums in Manifest differ for these files?
Comment 18 Jared B. 2011-10-29 19:25:01 UTC
(In reply to comment #17)
> Do the checksums in Manifest differ for these files?

Nope, not according to the Manifest in sunrise.  As far as I can tell it's the same file, just a different name.
Comment 19 Jared B. 2012-09-15 02:54:06 UTC
Created attachment 323820 [details]
games-rpg/penumbra-collection-1.1.ebuild

minor update: unpacker eclass must now be explicitly included
Comment 20 Julian Ospald 2012-12-17 21:43:48 UTC
+*penumbra-collection-1.1 (17 Dec 2012)
+
+  17 Dec 2012; Julian Ospald <hasufell@gentoo.org>
+  +penumbra-collection-1.1.ebuild, +metadata.xml:
+  initial import based on work from Robert Cernansky wrt #278326
Comment 21 Róbert Čerňanský 2012-12-18 18:58:19 UTC
Thanks a lot for getting this into the main tree.  I have noticed some changes in the ebuild which does not look quite OK to me (I did not tried it yet though).

In src_install() the installation of bundled libs (if use amd64 ; then...) was moved above the 'exeinto "${destDir}"' line.  The code uses doexe so shouldn't it be moved below exeinto?

At the end of the src_install(), make_desktop_entry lines were replaced with for-loop where for each entry the "Penumbra: Overture" name is used.  I assume that this creates three "Penumbra: Overture" desktop/menu entries while each of them will be launching different game (Overture, Blackplague, Requiem).  If this was intentional I do not mind the change, just mentioning it to make sure that it was not overlooked.
Comment 22 Julian Ospald 2012-12-18 19:03:57 UTC
(In reply to comment #21)
> Thanks a lot for getting this into the main tree.  I have noticed some
> changes in the ebuild which does not look quite OK to me (I did not tried it
> yet though).
> 
> In src_install() the installation of bundled libs (if use amd64 ; then...)
> was moved above the 'exeinto "${destDir}"' line.  The code uses doexe so
> shouldn't it be moved below exeinto?

no, there are 2 different exeinto/doexe which are unrelated:
one for the binary/shell script
one for the libraries (which is inside the if clause)

> 
> At the end of the src_install(), make_desktop_entry lines were replaced with
> for-loop where for each entry the "Penumbra: Overture" name is used.  I
> assume that this creates three "Penumbra: Overture" desktop/menu entries
> while each of them will be launching different game (Overture, Blackplague,
> Requiem).  If this was intentional I do not mind the change, just mentioning
> it to make sure that it was not overlooked.

right, that is a cosmetic error, will fix.