Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 277539 - app-arch/pbzip2: Add symlink USE flag to create b{,un}zip2 symlinks
Summary: app-arch/pbzip2: Add symlink USE flag to create b{,un}zip2 symlinks
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Gentoo LiveCD Package Maintainers
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2009-07-12 21:12 UTC by Michał Górny
Modified: 2009-09-05 18:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to add USE=symlink to ebuild (pbzip2-1.0.5-r2.ebuild.diff,1.24 KB, patch)
2009-07-12 21:15 UTC, Michał Górny
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-07-12 21:12:40 UTC
In my opinion, app-arch/pbzip2 ebuilds should include 'symlink' USEflag which would cause them to create symlinks /usr/b{,un}zip2 pointing to pbzip2 binary. This would allow users to easily replace original bzip2 implementation with SMP-capable one when /usr is available.

pbzip2 seems to be fully syntax-compatible with original bzip2 implementation. Although their output differs, I don't think that could cause problems with any scripts using bzip2 binaries. After creating symlinks, everything seems to work fine. 'bunzip2' and 'bzcat' work correctly too.

The symlinks would be placed in /usr/bin (because pbzip2 requires libstdc++) and thus won't collide with real bzip2 binaries in /bin.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-07-12 21:15:22 UTC
Created attachment 197672 [details, diff]
Patch to add USE=symlink to ebuild
Comment 2 Andrew Gaffney (RETIRED) gentoo-dev 2009-07-19 18:04:10 UTC
Does upstream support this?
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-07-19 21:33:40 UTC
(In reply to comment #2)
> Does upstream support this?

I didn't contact upstream about that. I think that's more ebuild-related issue.
Comment 4 Andrew Gaffney (RETIRED) gentoo-dev 2009-07-19 22:09:35 UTC
Not really. If upstream doesn't "support" that configuration, there's no reason for the ebuild to. We like to ship stuff as close to upstream as possible.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-07-19 22:12:41 UTC
Ok, I'll email upstream then and see what do they think of it.
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2009-07-20 21:02:06 UTC
Quoting:
> The latest pbzip2 should be syntax-compatible with bzip2 so I don't
> see why that shouldn't work.  I'm not sure what they mean by if
> upstream "supports" that configuration or not.  The pbzip2 binary will
> look at how it is being called and if it is named something "unzip"
> like bunzip2 or "zcat" like bzcat then it will act in the appropriate
> way so as far as I can tell it "supports" this configuration already.
>
> I have never tested your proposal on Gentoo so you might want to test
> to make sure everything works, but you can reply to the bug and say
> the upstream (pbzip2 upstream at least) says that the proposed use of
> symlinks should be supported by the latest version of the code.
>
> Jeff.
Comment 7 Chris Gianelloni 2009-09-04 16:31:59 UTC
Well, Jeff has given his (somewhat) approval, so I see no reason *not* to do this.

I have bumped the ebuild in my overlay (layman -ka wolf31o2) with these changes.  If someone wants to test them, then push them to the main tree for me, I would be appreciative.
Comment 8 Andrew Gaffney (RETIRED) gentoo-dev 2009-09-05 18:31:07 UTC
This is in the tree.