I have identified some static array issues in xchat-xsys. The netstream_cb callback in xsys.c tries to stuff up to 5 characters into the 3 character 'mag_r' array. Another issued I noticed (by compile time warning from GCC) was an off by one in the use of strncat - a classic. Patch attached. Reproducible: Always Steps to Reproduce: Receive on your network interface at a rate greater than 1 KB/s and then use "/netstream" in channel.
Created attachment 197584 [details] Updated ebuild
Created attachment 197586 [details, diff] Fix
The 2.2.0-r2 ebuild still hasn't been added to portage, is that going to happen?
Created attachment 310487 [details] 2.2.0-overflow.patch That patch doesn't apply for me :(
Probably a candidate for treecleaning due this unresolved overflows from years and looks to be unmaintained for a long time
Yes. I lost interest in this a long time ago. By all means Pacho.
I am still using this and the patch works. If chainsaw does not want to maintain it anymore I will take over ebuild maintainership.
To confirm, I have supplied Julian "hasufell" Ospald with the preliminary X-Sys 3.0.0 source code. It addresses this overflow and adds Conspire plugin interface support. With Conspire now abandoned, this may well be removed before it sees the light of day, but I just wanted to confirm that he is the new upstream for this codebase and that my maintainer tag should be removed at the earliest available opportunity. A new homepage should be provided, etc.
erm what?
seems it is already forked and available via hexchat "plugins" useflag: https://github.com/hexchat/hexchat/tree/master/plugins/sysinfo
Should this still be treecleaned? :/
yes, in case I want to work on this I will do so in the hexchat fork
dropped
