Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 277320 - x11-misc/synergy-plus ebuild: a maintenance fork of x11-misc/synergy
Summary: x11-misc/synergy-plus ebuild: a maintenance fork of x11-misc/synergy
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Default Assignee for New Packages
URL: http://code.google.com/p/synergy-plus/
Whiteboard:
Keywords:
: 289255 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-07-10 15:56 UTC by Ryan
Modified: 2010-06-03 14:48 UTC (History)
9 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
synergy-plus-1.3.4.ebuild (synergy-plus-1.3.4.ebuild,1.23 KB, text/plain)
2009-07-10 15:57 UTC, Ryan
Details
synergy-plus-1.3.4.ebuild (synergy-plus-1.3.4.ebuild,1.17 KB, text/plain)
2009-07-25 13:55 UTC, Ryan
Details
synergy-plus-1.3.4.ebuild (synergy-plus-1.3.4.ebuild,1019 bytes, text/plain)
2009-07-25 15:58 UTC, Ishan Arora
Details
synergy-plus-1.3.4.ebuild (synergy-plus-1.3.4.ebuild,1.07 KB, text/plain)
2009-07-25 16:21 UTC, Ishan Arora
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan 2009-07-10 15:56:41 UTC
Synergy has been lacking a proper release for a while. There hasn't been much development lately either. Synergy-Plus is right now just a maintenance release, with future release planning on introducing new features.

Attached is an ebuild, doesn't seem there is much to it right now.

I tried running eautoreconf and econf in the src_configure() , but it wasn't running so I moved it to src_compile, but now I get QA Notices, not sure what the proper approach is.

I have tested this ebuild on a ~amd64 box, and it is connecting to a synergy2 release running on OS X 10.4
Comment 1 Ryan 2009-07-10 15:57:14 UTC
Created attachment 197465 [details]
synergy-plus-1.3.4.ebuild
Comment 2 Ryan 2009-07-10 19:40:00 UTC
I mistakenly marked this ebuild as 1.3.4, thinking it was the latest release, but it is actually 1.3.3
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-07-13 14:20:01 UTC
Thanks Ryan, this really looks interesting, although the fact that it needs an eautoreconf run means upstream has no clue about packaging the stuff (and the way they name the tarball also suggests so)… sigh.

If you can reach upstream and convince them that for Linux distributions it's MUCH better if they just run "make dist", then that would be fantastic. I'd sincerely rather not add this to the tree until they decide to do that because it's a huge hassle to deal with such upstream usually...
Comment 4 Ryan 2009-07-13 14:55:19 UTC
Thanks I'll reach out to them and see.
Comment 5 Ryan 2009-07-13 19:01:21 UTC
the relevant synergy-plus request.
http://code.google.com/p/synergy-plus/issues/detail?id=105
Comment 6 Nick Bolton 2009-07-14 11:11:54 UTC
Please could you give this some time? As you can tell this is a relatively new fork and we haven't had chance to get started. The current tar.gz has been uploaded for convenience of developers, not end users, hence why it is named after the Mercurial revision and not the version number. Once we get to stable 1.3.4 we will release, synergy-plus-1.3.4.tar.gz - but we may also be using the SCons or CMake build system.
Comment 7 Nick Bolton 2009-07-14 15:37:21 UTC
I've added a tar.gz created with `make dist` and added it to the downloads page.

http://code.google.com/p/synergy-plus/downloads/list

Please bare in mind this is an unstable release :)
Comment 8 Ryan 2009-07-15 03:39:13 UTC
fyi, it would still be beneficial to not have the commit hash in the package name, it would require extra work to modify the ebuild every time to change the build package. Granted a small request but it makes version bumps easier.

Thanks for the cooperation, imho, it is nice to see developers work with the package maintainers of distro's
Comment 9 Nick Bolton 2009-07-15 11:17:25 UTC
Thanks, happy to help. The commit hash is to indicate that it's not a stable version of the code; it's version 1.3.3, with a few fixes. I realise that this is unusual, but it's because version 1.3.3 existed before I joined the project, and doesn't compile on Linux.
Comment 10 Ryan 2009-07-15 13:34:44 UTC
I can understand that now. I would say that a version scheme needs to be thought out. Obviously, you have the x.y.z , but maybe you do what the kernel does, and instead of bumping to 1.3.4, when you already have that release planned, and these are just bug fixes, you label it 1.3.3.1. It makes it easier for package maintainers to version the packages and gives a clear lable that 1.3.3.1 is a later release the 1.3.3 
Comment 11 Nick Bolton 2009-07-15 23:15:44 UTC
Hmm, fair point. To be honest, I don't like the revision number tagged on the end now I think about it. We could just bump up the rev number to 4... To be honest, it's pretty stable how it is, and since we dont have a 1.3.3 tar.gz I think this would be a fair exception, what do you think?
Comment 12 Ryan 2009-07-16 13:39:27 UTC
you could do that also, Make you planned releases 1.x and then your patch releases between planned ones being 1.x.y

So all the ones between major milestones are 1.3.4 , 1.3.5. Then when you reach the objectives you've set for a milestone, increment the package to 1.4.

I've never maintained releases or software projects, so I am just speaking from my schooling, and what I've seen in the open source community.
Comment 13 Ishan Arora 2009-07-25 09:58:32 UTC
(In reply to comment #7)
> I've added a tar.gz created with `make dist` and added it to the downloads
> page.
> 
> http://code.google.com/p/synergy-plus/downloads/list
> 
> Please bare in mind this is an unstable release :)
> 

http://code.google.com/p/synergy-plus/issues/detail?id=124

http://synergy-plus.googlecode.com/files/synergy-plus-1.3.4.tar.gz is 
expected to contain a directory named synergy-plus-1.3.4 instead of synergy-
plus-1.3.3
Comment 14 Nick Bolton 2009-07-25 11:36:19 UTC
Issue 124 has been fixed.
Comment 15 Ryan 2009-07-25 13:55:25 UTC
Created attachment 199131 [details]
synergy-plus-1.3.4.ebuild

Here is an updated ebuild, getting rid of the vars needed before, and simpilified the src_compile()

Also change the src_install to use emake instead of make, must of been a typo from before?

I don't have the ability to test it, but it compiles fine on ~amd64. Will be using it come Monday morning.
Comment 16 Kevin Pyle 2009-07-25 15:47:07 UTC
MY_PN is now unused, and relies on the undefined variable DIGEST.

Using 'make install' works, but 'emake install' is preferred if the package can install in parallel.

For a new ebuild, it would be nice, though by no means mandatory, to submit it as EAPI=2.

Regardless of whether you use EAPI=2, you can delete src_compile().  The default src_configure and src_compile in EAPI 2, according to <http://devmanual.gentoo.org/ebuild-writing/eapi/index.html#phases>, will do the right thing.  The EAPI 0 defaults appear to be equivalent to what you have now, as well.

As presently written, synergy-plus cannot be built while synergy is installed.  I can understand not being able to install both at the same time, but do you need to prohibit building as well?
Comment 17 Ishan Arora 2009-07-25 15:58:52 UTC
Created attachment 199147 [details]
synergy-plus-1.3.4.ebuild

Removed a few unneeded lines (inherits, MY_PN, src_compile) and changed the postinst elog text
Comment 18 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-07-25 16:06:52 UTC
The new ebuild looks fine but dodoc/doins of doc and examples should die too (and imho the example should be installed under docs rather than in /etc (I don't like my /etc polluted!)
Comment 19 Ishan Arora 2009-07-25 16:09:55 UTC
how about /etc/synergy.conf.example instead of  /etc/synergy.conf
Comment 20 Ishan Arora 2009-07-25 16:21:41 UTC
Created attachment 199149 [details]
synergy-plus-1.3.4.ebuild

EAPI=2 and die on doins and dodoc
Comment 21 Ishan Arora 2009-07-25 16:25:32 UTC
Comment on attachment 199149 [details]
synergy-plus-1.3.4.ebuild

also removed the build dependency on !x11-misc/synergy
Comment 22 Ishan Arora 2009-07-25 16:28:52 UTC
(In reply to comment #18)
> imho the example should be installed under docs rather than in /etc (I
> don't like my /etc polluted!)

I find that odd. I am used to seeing example files in /etc, look at samba (/etc/samba/smb.conf.example). Although I advice on adding a .example at the end of it, since this is not a default conf file.
Comment 23 Kevin Bowling 2009-09-27 21:19:06 UTC
Tested, works great on ~amd64.  Upstream is a non-starter with recent GCC and X11 releases.

Please add to tree.
Comment 24 Samuli Suominen (RETIRED) gentoo-dev 2009-10-16 00:59:31 UTC
*** Bug 289255 has been marked as a duplicate of this bug. ***
Comment 25 Miller Larson 2009-11-13 18:22:10 UTC
Confirmed working well on amd64 as well...

Wondering why this is masked by package.keywords and package.mask?

I'd enjoy seeing this in the tree as well.
Comment 26 Dror Levin (RETIRED) gentoo-dev 2010-06-03 14:48:15 UTC
Was added to the tree in October 2009 so closing as FIXED.