Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 277230 - [devmanual] update epatch section
Summary: [devmanual] update epatch section
Status: RESOLVED FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Devmanual (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks:
 
Reported: 2009-07-09 17:17 UTC by Mounir Lamouri (volkmar) (RETIRED)
Modified: 2010-07-18 16:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Fixing patch (epatch-update.patch,429 bytes, patch)
2009-07-09 17:19 UTC, Mounir Lamouri (volkmar) (RETIRED)
Details | Diff
Fixing patch (epatch-update.patch,500 bytes, patch)
2009-09-15 19:40 UTC, Mounir Lamouri (volkmar) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mounir Lamouri (volkmar) (RETIRED) gentoo-dev 2009-07-09 17:17:46 UTC
Devmanual mentions patch have to be mirrored compressed when too big.
It shows an example explaining how using such patch files: unpacking only source then using epatch on the compressed patch.
However, with EAPI-2, it's not helping because patch is done in src_prepare so the patch will be in ${WORKDIR} instead of ${DISTDIR}.

As the devmanual is mostly EAPI-0 aware, I don't think we should change the example to src_prepare but we should change the example to be EAPI-2 compatible.

See the attachment.
Comment 1 Mounir Lamouri (volkmar) (RETIRED) gentoo-dev 2009-07-09 17:19:02 UTC
Created attachment 197375 [details, diff]
Fixing patch
Comment 2 Mark Loeser (RETIRED) gentoo-dev 2009-07-12 19:22:30 UTC
That patch makes the example not work right anymore.  Come up with an example for EAPI 2 if that's what you are going for.
Comment 3 Mounir Lamouri (volkmar) (RETIRED) gentoo-dev 2009-07-12 22:54:20 UTC
(In reply to comment #2)
> That patch makes the example not work right anymore.

Don't get it. It's not breaking it. (I've just tested it with an EAPI-0 ebuild)
Comment 4 Mounir Lamouri (volkmar) (RETIRED) gentoo-dev 2009-09-15 19:40:21 UTC
Created attachment 204238 [details, diff]
Fixing patch

I don't see why you think it's breaking.
I've attached a new patch with comments to let user understand what's going on.
As I said in comment #0, it will help having code EAPI-0 and EAPI-2 compliant as src_prepare is doing unpack ${A}.
Comment 5 Tomáš Chvátal (RETIRED) gentoo-dev 2009-10-03 18:59:25 UTC
He means that it should be adjusted to show 2 phases:

src_unpack() {
 unpack ${A}
 epatch "${WORKDIR}"/Blesmrt.patch
}

or use simply: (since in eapi2 fallback for src_unpack() is unpack ${A})
src_prepare() {
 epatch "${WORKDIR}"/Blesmrt.patch
}
Comment 6 Markos Chandras (RETIRED) gentoo-dev 2010-07-18 16:59:12 UTC
Fixed