Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 276401 - net-mail/uw-mailutils should honor pam and ssl USE flags
Summary: net-mail/uw-mailutils should honor pam and ssl USE flags
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Net-Mail Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-03 21:34 UTC by DC
Modified: 2011-05-06 21:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch against uw-mailutils-2007e.ebuild (uw-mailutils.patch,667 bytes, patch)
2009-07-03 21:36 UTC, DC
Details | Diff
Updated patch to make $sslflags local (uw-mailutils.patch,699 bytes, patch)
2009-07-04 22:36 UTC, DC
Details | Diff
patch to uw-mailutils-2007e adding pam and ssl USE flags (uw-mailutils-alt.patch,1020 bytes, patch)
2009-07-05 08:06 UTC, Eray Aslan
Details | Diff
revize ssl dirs (uw-mailutils-ssl.patch,391 bytes, patch)
2009-07-05 08:07 UTC, Eray Aslan
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description DC 2009-07-03 21:34:43 UTC
net-mail/uw-mailutils-2007e currently builds with SSL and PAM disabled, regardless of whether they were requested by the USE flags. This patch enables SSL and PAM if the USE flags requested them.

Reproducible: Always

Steps to Reproduce:
Comment 1 DC 2009-07-03 21:36:54 UTC
Created attachment 196544 [details, diff]
Patch against uw-mailutils-2007e.ebuild
Comment 2 Eray Aslan gentoo-dev 2009-07-04 07:28:15 UTC
Perhaps it would be better if you

* declared sslflags as local
* quoted sslflags in the make statement.

Thanks for the patch.
Comment 3 DC 2009-07-04 22:31:19 UTC
Making sslflags local is a good idea -- thanks for the suggestion.

I don't want to quote sslflags though, because it's a string that can contain more than one make setting, and I want make to see them as separate args.
Comment 4 DC 2009-07-04 22:36:24 UTC
Created attachment 196690 [details, diff]
Updated patch to make $sslflags local
Comment 5 Eray Aslan gentoo-dev 2009-07-05 08:03:45 UTC
(In reply to comment #3)
> I don't want to quote sslflags though, because it's a string that can contain
> more than one make setting, and I want make to see them as separate args.

Two points:
* passing unquoted areguments is not safe enough
* SSLINCLUDE and SSLIB directives errors out when compiling mtest.c further down the emerge.

Please check the attachment for an alternative.

Comment 6 Eray Aslan gentoo-dev 2009-07-05 08:06:07 UTC
Created attachment 196719 [details, diff]
patch to uw-mailutils-2007e adding pam and ssl USE flags
Comment 7 Eray Aslan gentoo-dev 2009-07-05 08:07:43 UTC
Created attachment 196720 [details, diff]
revize ssl dirs
Comment 8 DC 2009-07-05 21:20:06 UTC
I tested your new patches, and they work for me. Thanks!
Comment 9 Eray Aslan gentoo-dev 2011-05-06 21:00:49 UTC
+*uw-mailutils-2007e-r1 (06 May 2011)
+
+  06 May 2011; Eray Aslan <eras@gentoo.org> +uw-mailutils-2007e-r1.ebuild,
+  +files/uw-mailutils-ssl.patch:
+  add pam and ssl USE flags - bugs 129729 276401
+