Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 276286 - media-sound/nted: fails with forced --as-needed
Summary: media-sound/nted: fails with forced --as-needed
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Matthias Vill
Depends on:
Blocks: as-needed
  Show dependency tree
Reported: 2009-07-02 20:08 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2009-07-11 10:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Build log (nted-1.6.0:20090702-193734.log,1.12 MB, text/plain)
2009-07-02 20:08 UTC, Diego Elio Pettenò (RETIRED)
proposed patch (makefile_am_ldflags.patch,1.14 KB, patch)
2009-07-09 20:35 UTC, Markos Chandras (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2009-07-02 20:08:18 UTC
I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out for details).

Please note that this bug _might_ apply to -Wl,--as-needed in LDFLAGS as well; in both cases it should be fixed. Also, if this is due to the package in question not respecting user-defined LDFLAGS, you should get to fix that too.

Check the attached build log.

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-07-02 20:08:55 UTC
Created attachment 196429 [details]
Build log
Comment 2 Markos Chandras (RETIRED) gentoo-dev 2009-07-09 20:35:07 UTC
Created attachment 197401 [details, diff]
proposed patch

This is the patch I came up with thanks to Diegos' suggestions. I cant test "foced --as-needed" cases on my machines, so please test it if you can and let me know if it works or not

Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-07-09 20:43:22 UTC
Patch looks good :)
Comment 4 Markos Chandras (RETIRED) gentoo-dev 2009-07-09 20:56:01 UTC
Thanks :)

Matthias, can you please send this patch upstream?
Thank you
Comment 5 Matthias Vill 2009-07-11 06:56:58 UTC
I'll do.

--as-needed is to let the compiler decide on libraries, right?
Comment 6 Markos Chandras (RETIRED) gentoo-dev 2009-07-11 10:01:17 UTC :)