Bug 276286 – media-sound/nted: fails with forced --as-needed

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Diego Elio Pettenò (RETIRED) 2009-07-02 20:08:18 UTC]

I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Please note that this bug _might_ apply to -Wl,--as-needed in LDFLAGS as well; in both cases it should be fixed. Also, if this is due to the package in question not respecting user-defined LDFLAGS, you should get to fix that too.

Check the attached build log.

Thanks,
Diego

[Comment 1 Diego Elio Pettenò (RETIRED) 2009-07-02 20:08:55 UTC]

Created attachment 196429 [details]
Build log

[Comment 2 Markos Chandras (RETIRED) 2009-07-09 20:35:07 UTC]

Created attachment 197401 [details, diff]
proposed patch

This is the patch I came up with thanks to Diegos' suggestions. I cant test "foced --as-needed" cases on my machines, so please test it if you can and let me know if it works or not

Thanks

[Comment 3 Diego Elio Pettenò (RETIRED) 2009-07-09 20:43:22 UTC]

Patch looks good :)

[Comment 4 Markos Chandras (RETIRED) 2009-07-09 20:56:01 UTC]

Thanks :)
Commited

 
Matthias, can you please send this patch upstream?
Thank you

[Comment 5 Matthias Vill 2009-07-11 06:56:58 UTC]

I'll do.

--as-needed is to let the compiler decide on libraries, right?

[Comment 6 Markos Chandras (RETIRED) 2009-07-11 10:01:17 UTC]

http://www.gentoo.org/proj/en/qa/asneeded.xml :)