New Ebuild for Alarm Clock 1.0beta1 Reproducible: Always Steps to Reproduce:
Created attachment 195930 [details] alarm-clock-1.0_beta1.ebuild
- Don't use tar app directly into src_unpack() there is a function disigned for that purpose called "unpack". (tar can fails unpack dies itself) - Don't use "mv ${WORKDIR}/alarm-clock-1.0beta1/* ${WORKDIR}/", because ${S} is defined as ${WORKDIR}/${PN} as default, and you need to work into ${WORKDIR}/${PN} instead of ${WORKDIR} directly. - mv can fails (|| die statement is required) - src_unpack() is finally not necessary because defined as default using EAPI="0". - src_compile() is not necessary too, for the same reasons. have a look to http://devmanual.gentoo.org/ for more details, and if you've any problem don't hesitate to ask here ;)
(In reply to comment #2) > - Don't use tar app directly into src_unpack() there is a function disigned for > that purpose called "unpack". (tar can fails unpack dies itself) > > - Don't use "mv ${WORKDIR}/alarm-clock-1.0beta1/* ${WORKDIR}/", because ${S} is > defined as ${WORKDIR}/${PN} as default, and you need to work into > ${WORKDIR}/${PN} instead of ${WORKDIR} directly. > > - mv can fails (|| die statement is required) > > - src_unpack() is finally not necessary because defined as default using > EAPI="0". > > - src_compile() is not necessary too, for the same reasons. > > have a look to http://devmanual.gentoo.org/ for more details, and if you've > any problem don't hesitate to ask here ;) > By the way , header isn't up-to-date :)
you should also probably use base eclass since it does most of what you put into this ebuild.
this is an just working ebuild and its works i cant use $S cause the PN is NOT the name of the source package but the ebuild does not allow another PN in cause of invalid package atom alarm-clock-1.0_beta1 != alarm-clock-1.0beta1 thats why src_unpack() is needed! and thats why i did not uses $S
(In reply to comment #5) > this is an just working ebuild and its works > > i cant use $S cause the PN is NOT the name of the source package > > but the ebuild does not allow another PN in cause of invalid package atom > > alarm-clock-1.0_beta1 != alarm-clock-1.0beta1 > > thats why src_unpack() is needed! and thats why i did not uses $S > In this case Use MY_PN like this: MY_PV=${PV/_/} MY_PN=${PN}-${MY_PV} and use my ${MY_PN} instead of ${PN} (it's a standard spec), and in this case I repeat, src_unpack() function is unuseful, because unpack ${A} will be call and will unpack tarball as default. (into the default function) ${S} var is designed for that purpose, ie when the PN is not the same of the sources package (the dirname into WORKDIR), in this case you need to define it explicitly, otherwises it's implictly defined to "${WORKDIR}/${P}". So in our case : S=${WORKDIR}/${MY_P} and src_unpack() default function uses ${S} as default, so all is allright.
Use MY_PV=${PV/_/} or something else of course. It's not to blame you, it's to help you ;)
Created attachment 196484 [details] Alarm Clock 1.0 ebuild thx for the constructive help
Created attachment 200077 [details] alarm-clock-1.2.1.ebuild
Created attachment 205766 [details] Updated ebuild for alarm-clock-1.2.4
Created attachment 205782 [details] A better version of ebuild
Created attachment 214818 [details] gnome-extra/alarm-clock-1.2.5.ebuild
Jouni, thank just a few comments for ebuild: 1. Missed IUSE 2. SLOT deps (dev-python/pygtk:2) are available in EAPI="1" only. 3. it's good idea to move sed to src_unpack (or better USE EAPI="2" and use src_prepare) 4. pkg_postinst is redundant 5. inherit eutils is redundant Also I suggest you to take a look at Sunrise project and commit fixed ebuild into Sunrise overlay. Please refer to CodingStandards and HowToCommit on the project page for details: http://overlays.gentoo.org/proj/sunrise/ Currently I don't see why sunrise is in CC. Removing.
Seems like this is no longer needed with GNOME3 as there is a replacement for this. i opened this bug in 2009... wow :D good old times
