Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 275151 - app-emulation/kqemu-1.4.0_pre1: should install modprobe file /etc/modprobe.d/kqemu.conf
Summary: app-emulation/kqemu-1.4.0_pre1: should install modprobe file /etc/modprobe.d/...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Luca Barbato
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 274942
  Show dependency tree
 
Reported: 2009-06-23 08:06 UTC by Matthias Schwarzott
Modified: 2009-11-20 13:15 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for kqemu-1.4.0_pre1 ebuild to create /etc/modprobe.d/kqemu.conf (kqemu-1.4.0_pre1-dotconf.patch,914 bytes, patch)
2009-06-24 10:29 UTC, Ian Abbott
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Schwarzott gentoo-dev 2009-06-23 08:06:25 UTC
As modprobe will in future releases ignore every file not suffixed ".conf" app-emulation/kqemu should install its file as /etc/modprobe.d/kqemu.conf instead of /etc/modprobe.d/kqemu.

If user has made no changes to this file it should be enough to change the creating line, and portage unmerge-orphans should do the rest.

See Bug #274942
Comment 1 Ian Abbott 2009-06-24 10:29:23 UTC
Created attachment 195646 [details, diff]
Patch for kqemu-1.4.0_pre1 ebuild to create /etc/modprobe.d/kqemu.conf

Patch renames /etc/modprobe.d/kqemu to /etc/modprobe.d/kqemu.conf, or moves /etc/modules.d/kqemu to /etc/modprobe.d/kqemu.conf. New version of config file created as /etc/modprobe.d/kqemu.conf .
Comment 2 Matthias Schwarzott gentoo-dev 2009-07-20 09:35:37 UTC
(In reply to comment #1)
> 
> Patch renames /etc/modprobe.d/kqemu to /etc/modprobe.d/kqemu.conf, or moves
> /etc/modules.d/kqemu to /etc/modprobe.d/kqemu.conf. New version of config file
> created as /etc/modprobe.d/kqemu.conf .
> 
As this file is not supposed to be changed by users, I think unmerge-orphans is enough to remove the old file, so the pkg_preinst is not necessary.
Comment 3 Matthias Schwarzott gentoo-dev 2009-07-20 09:38:07 UTC
Should all ebuilds be changed to install the new filename or only kqemu-1.4.0_pre1.

I also can do the commit if you don't have the time.
Comment 4 Martin von Gagern 2009-07-23 17:14:13 UTC
(In reply to comment #2)
> As this file is not supposed to be changed by users, I think unmerge-orphans
> is enough to remove the old file, so the pkg_preinst is not necessary.

unmerge-orphans doesn't remove files in CONFIG_PROTECT, according to manual.
Bug #275910 gives a real-world example where a simple upgrade doesn't work.
Comment 5 Matthias Schwarzott gentoo-dev 2009-07-23 18:35:33 UTC
(In reply to comment #4)
> 
> unmerge-orphans doesn't remove files in CONFIG_PROTECT, according to manual.
> Bug #275910 gives a real-world example where a simple upgrade doesn't work.
> 
You are right, unmerge-orphans is for files outside CONFIG_PROTECT that now can be removed even if their mtime or content is changed.

Then I have no idea how that feature is called, but here the old /etc/modprobe.d/kqemu is automatically removed by portage, as I did not change this file.
Comment 6 Martin von Gagern 2009-07-24 07:10:31 UTC
(In reply to comment #5)
> Then I have no idea how that feature is called, but here the old
> /etc/modprobe.d/kqemu is automatically removed by portage, as I did not
> change this file.

OK, I assume the "not changed" part is checked using checksum and probably mtime as well. Still, two issues remain. One is different package managers. While portage might behave that way, do others as well? Does pms say anything here?

The other is the fact that although I agree that most users should not need to change their kqemu.conf, it is in /etc, it's not masked from config protection, and it does not contain a bug fat warning. So users might be justified in expecting that they may edit this file without breaking future upgrades.
Comment 7 Martin von Gagern 2009-09-27 16:45:37 UTC
Is there a good reason not to apply the patch from Ian and close this thing here?
Comment 8 Matthias Schwarzott gentoo-dev 2009-11-20 13:15:27 UTC
Commited your patch to kqemu-1.4.0_pre1-r1.