<snip> configure: WARNING: libnotify not found; notification disabled checking for dlopen... no checking for dlopen in -ldl... yes checking for ecvt... yes checking for fcvt... yes checking for pthread_mutex_init in -lpthread... yes checking for getstat in -lproc-3.2.7... no configure: error: libproc not found. Please configure without procps (using --without-procps) or install procps - http://procps.sourceforge.net !!! ERROR in app-emulation/open-vm-tools-0.0.20090522.167859: !!! In econf at line 1990 !!! econf failed !!! Call stack: !!! * econf (/var/tmp/paludis/app-emulation-open-vm-tools-0.0.20090522.167859/temp/loadsaveenv:1990) !!! * src_configure (/var/tmp/paludis/app-emulation-open-vm-tools-0.0.20090522.167859/temp/loadsaveenv:4751) !!! * ebuild_f_configure (/usr/libexec/paludis/2/src_configure.bash:52) !!! * ebuild_main (/usr/libexec/paludis/ebuild.bash:482) !!! * main (/usr/libexec/paludis/ebuild.bash:498) diefunc: making ebuild PID 2943 exit with error die trap: exiting with error. </snip> Check succeeds after a downgrade to sys-process/procps-3.2.7.
Upstream was *kind* enough to lock the check to procps-3.2.7. if test "$with_procps" = "yes"; then # XXX: Force CUSTOM_PROCPS_LIBS to have something so that AC_VMW_CHECK_LIB # properly performs the library check. if test -z "$CUSTOM_PROCPS_LIBS"; then CUSTOM_PROCPS_LIBS="-L/lib" fi AC_VMW_CHECK_LIB([proc-3.2.7], [PROCPS], [], [], [], [], [getstat], [VMWARE_USER_LDADD="$VMWARE_USER_LDADD $PROCPS_LIBS"], [AC_MSG_ERROR([libproc not found. Please configure without procps (using --without-procps) or install procps - http://procps.sourceforge.net])]) fi
Created attachment 194600 [details, diff] Patch to remove the lock on procps-3.2.7 detection This simple patch allows open-vm-tools to build procps-3.2.8. I'm going to have to make a few diffs between procps 3.2.6/3.2.7 to check for a function added to 3.2.7 and use that for the check to ensure the check doesn't match prior versions.
The open-vm-tools-propcs-check-fix.patch does NOT resolve the problem. The configure still fails with the same error.
(In reply to comment #3) > The open-vm-tools-propcs-check-fix.patch does NOT resolve the problem. The > configure still fails with the same error. > That isn't correct. I have test it today with the current release of the open-vm-tools-0.0.20090618.172495 package and this patch. Everything work as accepted. I my case the portage-2.2 preserved-rebuild feature protected the /lib/libproc-3.2.7.so because the open-vm-tools package needed it. You know that it isn't enough only to download the patch and put in the open-vm-tools package files dir. You need to add the line: epatch "${FILESDIR}/open-vm-tools-procps-check-fix" I had added it to the src_prepare() function as lastest command. regards j0inty
Hi, I have to revoked my last post and must say that Nickie Deuxyeux has right. The patch only fix the configure.ac file and the call directly the configure script. The ebuild needs to call the autoreconf script that will generate the configure script again without the dependency for proc-3.2.7. I made a patch for the last open-vm-tools ebuild and will post it here. This patch add a call of the eautoreconf function to src_prepare(). regards j0inty
Created attachment 197289 [details, diff] open-vm-tools-0.0.20090618.172495.ebuild.patch
Created attachment 197336 [details, diff] suggested_changes_for_r1.patch I've also done some hacking on the ebuild which I'd like to see included, please review.
Hi, I had tested our patch now and aftzer a review I think it's one of the best choice for the open-vm-tools ebuild. I saw you fixed some DEPEND and RDEPEND and added more needed configure arguments (like: --with-procps, --with-dnet or for X the gtk2 stuff) I only have 1 changes for this patch and that is the sed line for the configure and configure.ac script. But you only need to fix the configure.ac file, because eautoreconf generate a new configure script. Else as I can see you made a good job. regards j0inty
Timo, have you checked whether >=procps-3.2.7 is required? I haven't been able to do the diff between 3.2.6 and 3.2.7 to look for a suitable function for the check and didn't try building open-vm-tools with procps-3.2.6.
*open-vm-tools-0.0.20090618.172495-r1 (09 Jul 2009) 09 Jul 2009; Vadim Kuznetsov vadimk@gentoo.org +open-vm-tools-0.0.20090618.172495-r1.ebuild, metadata.xml: Fixes bugs 273211, 270433, 260878. Hardcoded procpc, Werror, general ebuild clean up and missing dependencies. USE flags are added: doc, fuse. However, vmblock-fuse still needs init script changes I did not forget about eautoreconf. It worked ok with eautoreconf on my ~arch machine, but compile failed on two stable machines. However without eautoreconf makefile is "trying to be clever" and runs autotools and configure second time. Not sure why it fails on stable. Leaving this bug open.
Actualy there is no need for autotools. And it screwed up plugin path fix. So, see -r2.
Vadim, how did you fix open-vm-tools-20090522? AFAICS, you're not using any patch, nor changing the autoconf detection code. Furthermore, open-vm-tools-20090618 is failing detecting procps-3.2.8 in exactly the same manner.
(In reply to comment #11) > Actualy there is no need for autotools. And it screwed up plugin path fix. So, > see -r2. Where do you have the -r2? I can't find it neither in the tree nor in the vmware overlay - http://overlays.gentoo.org/proj/vmware/browser/trunk/app-emulation/open-vm-tools
(In reply to comment #13) > (In reply to comment #11) > > Actualy there is no need for autotools. And it screwed up plugin path fix. So, > > see -r2. > > Where do you have the -r2? Here it is: http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-emulation/open-vm-tools/open-vm-tools-0.0.20090618.172495-r2.ebuild?rev=1.1&view=markup
(In reply to comment #12) > Vadim, > > how did you fix open-vm-tools-20090522? De jure, you are right. I did not. We are fixing 20090618. I hope it's ok. > AFAICS, you're not using any patch, nor > changing the autoconf detection code. Here are 3 new patches applied to 20090618 version: sed -i -e 's:VMTOOLSD_PLUGIN_ROOT=\\"\$(pkglibdir)\\":VMTOOLSD_PLUGIN_ROOT=\\"\$(pkglibdir)/plugins\\":g' \ services/vmtoolsd/Makefile.in || die "sed plugin path failed" sed -i -e 's/proc-3.2.7/proc/g' configure || die "sed configure failed" sed -i -e 's/CFLAGS=.*Werror/#&/g' configure || die "sed comment out Werror failed" > Furthermore, open-vm-tools-20090618 is failing detecting procps-3.2.8 in > exactly the same manner. > Based on you last comment i think you have not tried open-vm-tools-0.0.20090618.172495-r2.ebuild yet, right?
(In reply to comment #15) > Based on you last comment i think you have not tried > open-vm-tools-0.0.20090618.172495-r2.ebuild yet, right? Right. Seems I must have had a problem syncing here. Thanks and sorry for the noise.
