Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 272974 - Bump media-libs/ploticus-2.41
Summary: Bump media-libs/ploticus-2.41
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Daniel Black (RETIRED)
URL: http://ploticus.sourceforge.net/doc/d...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-06 21:03 UTC by Peter Alfredsen (RETIRED)
Modified: 2010-07-21 12:49 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ploticus-2.41.ebuild (ploticus-2.41.ebuild,3.81 KB, text/plain)
2009-12-27 09:20 UTC, Markus Peloquin
Details
pl241src.patch (pl241src.patch,480 bytes, patch)
2009-12-27 09:23 UTC, Markus Peloquin
Details | Diff
ploticus-2.41.ebuild (ploticus-2.41.ebuild,3.82 KB, text/plain)
2009-12-27 09:31 UTC, Markus Peloquin
Details
pl241src.patch (pl241src.patch,672 bytes, text/plain)
2009-12-27 09:33 UTC, Markus Peloquin
Details
pl241src.patch (pl241src.patch,950 bytes, patch)
2009-12-27 10:13 UTC, Markus Peloquin
Details | Diff
ploticus-2.41.ebuild (ploticus-2.41.ebuild,3.75 KB, text/plain)
2009-12-27 10:14 UTC, Markus Peloquin
Details
ploticus-2.41.ebuild (ploticus-2.41.ebuild,3.65 KB, text/plain)
2010-01-06 02:03 UTC, Markus Peloquin
Details
ploticus-2.41.ebuild (ploticus-2.41.ebuild,3.76 KB, patch)
2010-02-19 20:20 UTC, Markus Peloquin
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Alfredsen (RETIRED) gentoo-dev 2009-06-06 21:03:53 UTC
Available at $URL
Comment 1 Markus Peloquin 2009-12-27 09:20:30 UTC
Created attachment 214270 [details]
ploticus-2.41.ebuild

Some changes in ploticus are that there is now only a single Makefile, there is now a .so library (still experimental, and I am ignoring it), and the targets now require EXE to be set individually.

Something that should have been done already: install pl.h into /usr/include.

One more patch to come...
Comment 2 Markus Peloquin 2009-12-27 09:23:22 UTC
Created attachment 214272 [details, diff]
pl241src.patch

Porting over the ploticus-2.33 patch.

I should also note that I commented out the 'emake ... install' line in the ebuild, instead of removing it.
Comment 3 Markus Peloquin 2009-12-27 09:31:04 UTC
Created attachment 214274 [details]
ploticus-2.41.ebuild

Whoops.  Turns out the 'emake ... install' line was good for something.
Comment 4 Markus Peloquin 2009-12-27 09:33:26 UTC
Created attachment 214276 [details]
pl241src.patch

...

I thoroughly tested this on the ONE script I have.  Your mileage may vary
Comment 5 Markus Peloquin 2009-12-27 10:13:31 UTC
Created attachment 214283 [details, diff]
pl241src.patch

ffffffffffuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuu

Okay, so now it actually does the linking with X11, SVG, etc. right.  I also made sure to check in the Makefile for changed/removed definitions.  It passes all the tests in pl241src/pltestsuite/.

One thing that maybe should be done is setting PREFABS_DIR in api.c and preliminaries.c to some defaults (e.g. /usr/share/ploticus/prefabs).
Comment 6 Markus Peloquin 2009-12-27 10:14:21 UTC
Created attachment 214284 [details]
ploticus-2.41.ebuild

I will stop being a douche bag now.  This should totally work.
Comment 7 Markus Peloquin 2009-12-27 10:21:00 UTC
(as long as I'm adding myself to CC and therefore spamming [many apologies, Daniel], I will again note that the .so library is there but experimental)
Comment 8 Markus Peloquin 2010-01-06 02:03:22 UTC
Created attachment 215358 [details]
ploticus-2.41.ebuild

Whoops.  I didn't notice that pl.h includes plg.h.  Installing that as well.  I have to wonder about the quality of these headers, though.  Stuff like this troubles me:

  #define X 'x'
  #define YES 1
Comment 9 Thomas Kreuzer 2010-02-15 16:06:22 UTC
The new ebuild doesn't work for me:

>>> Install ploticus-2.41 into /var/tmp/portage/media-libs/ploticus-2.41/image/ category media-libs
make -j3 INSTALLBIN=/var/tmp/portage/media-libs/ploticus-2.41/image/usr/bin EXE=pl install 
cp pl /var/tmp/portage/media-libs/ploticus-2.41/image/usr/bin
cp: cannot stat `pl': No such file or directory
make: *** [install] Error 1

 * ERROR: media-libs/ploticus-2.41 failed:
 *   (no error message)
 * 
 * Call stack:
 *     ebuild.sh, line  54:  Called src_install
 *   environment, line 2332:  Called die
 * The specific snippet of code:
 *       emake INSTALLBIN=${D}usr/bin EXE="${EXE}" install || die;
Comment 10 Thomas Kreuzer 2010-02-19 19:52:51 UTC
I found the problem, the above mentioned error only comes when the USE flag "gd" is _not_ enabled.
I hope this helps.
Comment 11 Markus Peloquin 2010-02-19 20:20:46 UTC
Created attachment 220389 [details, diff]
ploticus-2.41.ebuild

I think previous ploticus versions ignored the EXE= make option in some cases.  Specifying EXE=plnogd used to make an executable called 'pl', but now it writes to 'plnogd'.

Solution: USE=-gd builds change from 'make ... EXE=plnogd plnogd' to 'make ... EXE=pl plnogd'.
Comment 12 Samuli Suominen (RETIRED) gentoo-dev 2010-07-21 12:49:42 UTC
Removed from tree.