Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 272720 - dev-libs/xapian (ab)uses valgrind during tests phase
Summary: dev-libs/xapian (ab)uses valgrind during tests phase
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on: 383001
Blocks:
  Show dependency tree
 
Reported: 2009-06-05 02:43 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2012-03-08 12:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2009-06-05 02:43:21 UTC
There is an automagic build-time dependency over valgrind when running the testsuite; I cannot tell you much about it but I see it running right now, and it takes _quite_ some time.

Maybe it should be put as an USE flag or simply dropped out of testing; the memcheck log output is not something we should probably be caring about by default.

Thanks,
Diego
Comment 1 Anthony Basile gentoo-dev 2010-12-14 18:03:06 UTC
xapian has been without a maintainer for a while, so I looked at this (since I'm taking care of valgrind).

I think the way to go is to just DEPEND on valgrind rather than drop it.  The tests take 7 minutes on an 8 core (well 4 core x 2 hyperthreading) i7 2.67GHz and are useful.

I don't understand why/how you would USE-depend on valgrind since its integrally part of some of the tests.

I'll wait a will for some feedback and then just add valgrind to DEPENDS.

Aside: xapian looks like a nice lib and should have a maintainer, but I don't know if I want to take on more.

Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-12-14 18:12:25 UTC
No, valgrind has to go. Valgrind is *not* an acceptable reproducible test tool:

 - it won't work with new glibc versions causing false positives;
 - it won't work with code built with SSE4 or other new instruction sets.

So please, DO NOT force valgrind, rather add an USE flag for it that is disabled by default.
Comment 3 Johan Bergström 2011-09-14 22:51:03 UTC
I just filed a version bump for xapian (see bug 383001) which _Should_ fix this issue (i.e.,not run valgrind in tests). Please verify. thanks!
Comment 4 Anthony Basile gentoo-dev 2011-09-15 11:33:59 UTC
Once we stabilize 1.2.7 valgrind will be out of the picture and we'll close this bug.
Comment 5 Anthony Basile gentoo-dev 2012-03-08 12:21:11 UTC
1.2.8 is stable.