272575 – app-cdr/cdw: fails with forced --as-needed

Bug 272575 - app-cdr/cdw: fails with forced --as-needed

Summary: app-cdr/cdw: fails with forced --as-needed

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High QA (vote)
Assignee:	Mr. Bones. (RETIRED)

URL:	http://www.gentoo.org/proj/en/qa/asne...
Whiteboard:
Keywords:

Depends on:
Blocks:	as-needed
	Show dependency tree

Reported:	2009-06-04 11:54 UTC by Diego Elio Pettenò (RETIRED)
Modified:	2009-10-16 19:53 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Build log (cdw-0.3.92:20090604-022512.log,150.66 KB, text/plain) 2009-06-04 11:55 UTC, Diego Elio Pettenò (RETIRED)	Details
First part (cdw-0.3.93.ebuild.patch,271 bytes, patch) 2009-09-28 02:49 UTC, Arseny Solokha	Details \| Diff
Second part (cdw-linking.patch,489 bytes, patch) 2009-09-28 02:54 UTC, Arseny Solokha	Details \| Diff
adding patch to ebuild (cdw-0.3.93.diff,235 bytes, patch) 2009-10-16 17:20 UTC, Kacper Kowalik (Xarthisius) (RETIRED)	Details \| Diff
fixing as-needed issues (cdw-0.3.93-as-needed.patch,916 bytes, patch) 2009-10-16 17:20 UTC, Kacper Kowalik (Xarthisius) (RETIRED)	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2009-06-04 11:54:53 UTC

I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Please note that this bug _might_ apply to -Wl,--as-needed in LDFLAGS as well; in both cases it should be fixed. Also, if this is due to the package in question not respecting user-defined LDFLAGS, you should get to fix that too.

Check the attached build log.

Thanks,
Diego

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2009-06-04 11:55:41 UTC

Created attachment 193497 [details]
Build log

Comment 2 Arseny Solokha 2009-09-28 02:48:18 UTC

Please review the following patchset.

Comment 3 Arseny Solokha 2009-09-28 02:49:28 UTC

Created attachment 205436 [details, diff]
First part

Comment 4 Arseny Solokha 2009-09-28 02:54:12 UTC

Created attachment 205438 [details, diff]
Second part

My emerge fails on unresolved symbols related to standard math functions, so I've added -lm to AM_LDFLAGS as well.

Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev

2009-09-28 08:57:58 UTC

Comment on attachment 205438 [details, diff]
Second part

The problem to begin with is that _it shouldn't be passing libraries to AM_LDFLAGS_ !

Comment 6 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2009-10-16 17:20:32 UTC

Created attachment 207336 [details, diff]
adding patch to ebuild

Just copy of http://bugs.gentoo.org/attachment.cgi?id=205436 for completeness

Comment 7 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev

2009-10-16 17:20:53 UTC

Created attachment 207337 [details, diff]
fixing as-needed issues

Comment 8 Mr. Bones. (RETIRED) gentoo-dev

2009-10-16 19:53:18 UTC

in portage.  thanks for the patch.