Bug 272242 – dev-libs/botan: breaks with forced --as-needed

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Diego Elio Pettenò (RETIRED) 2009-06-02 09:47:11 UTC]

I'm reporting this bug because the package in summary breaks (tests shows that, linking against it would do, too) when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Please note that this bug _might_ apply to -Wl,--as-needed in LDFLAGS as well; in both cases it should be fixed. Also, if this is due to the package in question not respecting user-defined LDFLAGS, you should get to fix that too.

Check the attached build log.

Thanks,
Diego

[Comment 1 Diego Elio Pettenò (RETIRED) 2009-06-02 09:48:16 UTC]

Created attachment 193267 [details]
Build log

[Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2009-06-06 19:02:16 UTC]

It ignores LDFLAGS:

 * QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:
 * /usr/lib64/libbotan-1.8.0.so

[Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2009-06-06 19:59:38 UTC]

Jack Lloyd:
You're Botan upstream developer, so please commit the attached patch.

[Comment 4 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2009-06-06 20:02:33 UTC]

Created attachment 193751 [details, diff]
botan-1.8.2-respect_LDFLAGS.patch

Libraries ($(LINK_TO)) should be specified after .o files ($(LIBOBJS)).

[Comment 5 Arfrever Frehtes Taifersar Arahesis (RETIRED) 2009-06-06 20:04:01 UTC]

Fixed.

[Comment 6 Jack Lloyd 2009-06-06 20:07:29 UTC]

Applied to upstream, will be included in the next stable release. Thank you for the patch and CC.