Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 272242 - dev-libs/botan: breaks with forced --as-needed
Summary: dev-libs/botan: breaks with forced --as-needed
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Jack Lloyd
Depends on:
Blocks: as-needed
  Show dependency tree
Reported: 2009-06-02 09:47 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2009-06-06 20:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Build log (dev-libs:botan-1.8.0:20090602-052125.log,465.92 KB, text/plain)
2009-06-02 09:48 UTC, Diego Elio Pettenò (RETIRED)
botan-1.8.2-respect_LDFLAGS.patch (botan-1.8.2-respect_LDFLAGS.patch,728 bytes, patch)
2009-06-06 20:02 UTC, Arfrever Frehtes Taifersar Arahesis (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2009-06-02 09:47:11 UTC
I'm reporting this bug because the package in summary breaks (tests shows that, linking against it would do, too) when forcing --as-needed on through spec files (check out for details).

Please note that this bug _might_ apply to -Wl,--as-needed in LDFLAGS as well; in both cases it should be fixed. Also, if this is due to the package in question not respecting user-defined LDFLAGS, you should get to fix that too.

Check the attached build log.

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-06-02 09:48:16 UTC
Created attachment 193267 [details]
Build log
Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2009-06-06 19:02:16 UTC
It ignores LDFLAGS:

 * QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:
 * /usr/lib64/
Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2009-06-06 19:59:38 UTC
Jack Lloyd:
You're Botan upstream developer, so please commit the attached patch.
Comment 4 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2009-06-06 20:02:33 UTC
Created attachment 193751 [details, diff]

Libraries ($(LINK_TO)) should be specified after .o files ($(LIBOBJS)).
Comment 5 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2009-06-06 20:04:01 UTC
Comment 6 Jack Lloyd 2009-06-06 20:07:29 UTC
Applied to upstream, will be included in the next stable release. Thank you for the patch and CC.