Bug 272163 – =www-plugins/mplayerplug-in-3.55-r1 requires firefox3[xulrunner] even when builing w/o USE=firefox

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Michał Górny 2009-06-01 21:39:24 UTC]

mplayerplug-in-3.55-r1 ebuild checks USEflags of firefox3 ebuild independently of 'firefox' USEflag. Thus, it refuses to build mplayerplug-in when it's meant to link against xulrunner and some xulrunner-less Firefox3 lies on the system.

Example situation is when user wants to build all of his plugins against xulrunner-1.8 but also wants to have a copy of Firefox3.

I suggest fixing that by simply doing Firefox version check only if appriopriate USEflags are desired. I attach fixed & cleaned up ebuild.

[Comment 1 Michał Górny 2009-06-01 21:40:43 UTC]

Created attachment 193190 [details]
Fixed ebuild

[Comment 2 Lars Wendler (Polynomial-C) (RETIRED) 2009-06-06 17:18:18 UTC]

Please attach unified diffs (diff -u) when you did changes to an ebuild. That would be much more handy for our devs.

[Comment 3 Michał Górny 2009-06-06 20:10:42 UTC]

Created attachment 193752 [details, diff]
diff

Here you are.

[Comment 4 Jory A. Pratt 2009-07-02 03:53:14 UTC]

(In reply to comment #3)
> Created an attachment (id=193752) [edit]
> diff
> 
> Here you are.
> 

Patch is still broken, firefox-3.5 has no xulrunner useflag it is a dep that is not gonna go away from here on out.

[Comment 5 Jory A. Pratt 2009-07-12 14:51:57 UTC]

Already fixed in tree.

[Comment 6 Nirbheek Chauhan (RETIRED) 2009-07-12 18:07:21 UTC]

Was fixed in-tree w/o a bump sometime ago...